diff mbox

[dpdk-dev] net/bonding: remove useless assignment

Message ID 20170124211555.16539-1-emmanuel.roullit@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Emmanuel Roullit Jan. 24, 2017, 9:15 p.m. UTC 
  Found with clang static analysis:
drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
warning: Value stored to 'num_not_send' is never read
        num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
        ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 73db5badb042 ("net: align ethdev and eal driver names")

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit Jan. 25, 2017, 12:11 p.m. UTC | #1 
On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
> warning: Value stored to 'num_not_send' is never read
>         num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
>         ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Applied to dpdk-next-net/master, thanks.
Ferruh Yigit Jan. 26, 2017, 11:08 a.m. UTC | #2 
On 1/25/2017 12:11 PM, Ferruh Yigit wrote:
> On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
>> Found with clang static analysis:
>> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
>> warning: Value stored to 'num_not_send' is never read
>>         num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
>>         ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> Applied to dpdk-next-net/master, thanks.

Fixes: 06fe78b98ccd ("bond: add mode 6")
Cc: stable@dpdk.org
Yuanhan Liu Feb. 14, 2017, 6:11 a.m. UTC | #3 
On Thu, Jan 26, 2017 at 11:08:29AM +0000, Ferruh Yigit wrote:
> On 1/25/2017 12:11 PM, Ferruh Yigit wrote:
> > On 1/24/2017 9:15 PM, Emmanuel Roullit wrote:
> >> Found with clang static analysis:
> >> drivers/net/bonding/rte_eth_bond_pmd.c:903:3:
> >> warning: Value stored to 'num_not_send' is never read
> >>         num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
> >>         ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Fixes: 73db5badb042 ("net: align ethdev and eal driver names")
> >>
> >> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> > 
> > Applied to dpdk-next-net/master, thanks.
> 
> Fixes: 06fe78b98ccd ("bond: add mode 6")
> Cc: stable@dpdk.org

For the same reason (it didn't fix a real bug), I will drop it to a
stable release.

	--yliu
diff mbox

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 02e34483f..f3ac9e273 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -900,7 +900,6 @@  bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 		}
 
 		num_tx_total += num_send;
-		num_not_send += slave_bufs_pkts[RTE_MAX_ETHPORTS] - num_send;
 	}
 
 	return num_tx_total;