[dpdk-dev] doc: update the document for virtio xstats feature

Message ID 1486460430-115698-1-git-send-email-jiayu.hu@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation fail Compilation issues

Commit Message

Hu, Jiayu Feb. 7, 2017, 9:40 a.m. UTC
  Currently, extended statistics has been supported by virtio. But there
are no corresponding document updates. Therefore, this patch is to update
the document for virtio xstats feature.

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
 doc/guides/nics/features/virtio.ini | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Remy Horton Feb. 7, 2017, 11:52 a.m. UTC | #1
Does virtio_vec.ini need updating as well?

On 07/02/2017 09:40, Jiayu Hu wrote:
> Currently, extended statistics has been supported by virtio. But there
> are no corresponding document updates. Therefore, this patch is to update
> the document for virtio xstats feature.
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
>  doc/guides/nics/features/virtio.ini | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Remy Horton <remy.horton@intel.com>
  
Yuanhan Liu Feb. 8, 2017, 1:40 a.m. UTC | #2
On Tue, Feb 07, 2017 at 05:40:30PM +0800, Jiayu Hu wrote:
> Currently, extended statistics has been supported by virtio. But there
> are no corresponding document updates. Therefore, this patch is to update
> the document for virtio xstats feature.
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu
  
Hu, Jiayu Feb. 9, 2017, 5:47 a.m. UTC | #3
On Tue, Feb 07, 2017 at 11:52:00AM +0000, Remy Horton wrote:
> Does virtio_vec.ini need updating as well?
I think not, since virtio_vec doesn't support xstats currently.
> 
> On 07/02/2017 09:40, Jiayu Hu wrote:
> > Currently, extended statistics has been supported by virtio. But there
> > are no corresponding document updates. Therefore, this patch is to update
> > the document for virtio xstats feature.
> > 
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > ---
> >  doc/guides/nics/features/virtio.ini | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Acked-by: Remy Horton <remy.horton@intel.com>
  
Thomas Monjalon Feb. 9, 2017, 3:12 p.m. UTC | #4
> > Currently, extended statistics has been supported by virtio. But there
> > are no corresponding document updates. Therefore, this patch is to update
> > the document for virtio xstats feature.
> > 
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> 
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Fixes: 76d4c652e07d ("virtio: add extended stats")

Applied, thanks
  

Patch

diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini
index 5164937..84d2012 100644
--- a/doc/guides/nics/features/virtio.ini
+++ b/doc/guides/nics/features/virtio.ini
@@ -15,6 +15,7 @@  Multicast MAC filter = Y
 VLAN filter          = Y
 Basic stats          = Y
 Stats per queue      = Y
+Extended stats       = Y
 Multiprocess aware   = Y
 BSD nic_uio          = Y
 Linux UIO            = Y