diff mbox

[dpdk-dev] app/crypto-perf: fix total_ops value validation

Message ID 1486470016-31047-1-git-send-email-kubax.kozak@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation fail Compilation issues

Commit Message

Kuba Kozak Feb. 7, 2017, 12:20 p.m. UTC 
  Added total_ops value validation in parse_total_ops() function.

Coverity issue: 141070

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
---
 app/test-crypto-perf/cperf_options_parsing.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo Feb. 9, 2017, 11:17 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> Sent: Tuesday, February 07, 2017 12:20 PM
> To: Doherty, Declan
> Cc: dev@dpdk.org; Kozak, KubaX
> Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation
> 
> Added total_ops value validation in parse_total_ops() function.
> 
> Coverity issue: 141070
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> 
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo Feb. 9, 2017, 11:25 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Thursday, February 09, 2017 11:18 PM
> To: Kozak, KubaX; Doherty, Declan
> Cc: dev@dpdk.org; Kozak, KubaX
> Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value
> validation
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> > Sent: Tuesday, February 07, 2017 12:20 PM
> > To: Doherty, Declan
> > Cc: dev@dpdk.org; Kozak, KubaX
> > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value
> validation
> >
> > Added total_ops value validation in parse_total_ops() function.
> >
> > Coverity issue: 141070
> >
> > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> > application")
> >
> > Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 3b7342d..3a8b898 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -128,7 +128,13 @@  struct name_id_map {
 	int ret = parse_uint32_t(&opts->total_ops, arg);
 
 	if (ret)
-		RTE_LOG(ERR, USER1, "failed to parse total operations count");
+		RTE_LOG(ERR, USER1, "failed to parse total operations count\n");
+
+	if (opts->total_ops == 0) {
+		RTE_LOG(ERR, USER1,
+				"invalid total operations count number specified\n");
+		return -1;
+	}
 
 	return ret;
 }