diff mbox

[dpdk-dev] net/i40e: Fix a typo in i40e_flow.c.

Message ID 20170227045359.20479-1-rami.rosen@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rami Rosen Feb. 27, 2017, 4:53 a.m. UTC 
  This patch fixes a trivial typo in i40e_flow.c.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

John McNamara Feb. 27, 2017, 3:50 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Monday, February 27, 2017 4:54 AM
> To: dev@dpdk.org
> Cc: Rosen, Rami <rami.rosen@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.
> 
> This patch fixes a trivial typo in i40e_flow.c.
> 
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
Ferruh Yigit Feb. 27, 2017, 4:31 p.m. UTC | #2 
On 2/27/2017 3:50 PM, Mcnamara, John wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
>> Sent: Monday, February 27, 2017 4:54 AM
>> To: dev@dpdk.org
>> Cc: Rosen, Rami <rami.rosen@intel.com>
>> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.
>>
>> This patch fixes a trivial typo in i40e_flow.c.
>>
>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

    net/i40e: fix a typo in flow

    Fixes: 47c6782344b7 ("net/i40e: fix tunnel filter")
    Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
    Cc: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.
Yuanhan Liu Feb. 28, 2017, 2:32 a.m. UTC | #3 
On Mon, Feb 27, 2017 at 04:31:28PM +0000, Ferruh Yigit wrote:
> On 2/27/2017 3:50 PM, Mcnamara, John wrote:
> > 
> > 
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> >> Sent: Monday, February 27, 2017 4:54 AM
> >> To: dev@dpdk.org
> >> Cc: Rosen, Rami <rami.rosen@intel.com>
> >> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.
> >>
> >> This patch fixes a trivial typo in i40e_flow.c.
> >>
> >> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
> > 
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> 
>     net/i40e: fix a typo in flow
> 
>     Fixes: 47c6782344b7 ("net/i40e: fix tunnel filter")
>     Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
>     Cc: stable@dpdk.org

I think we don't have to put a (comment) typo fix patch into a stable
release, though it does no harm.

	--yliu
Ferruh Yigit March 1, 2017, 6:41 p.m. UTC | #4 
On 2/28/2017 2:32 AM, Yuanhan Liu wrote:
> On Mon, Feb 27, 2017 at 04:31:28PM +0000, Ferruh Yigit wrote:
>> On 2/27/2017 3:50 PM, Mcnamara, John wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
>>>> Sent: Monday, February 27, 2017 4:54 AM
>>>> To: dev@dpdk.org
>>>> Cc: Rosen, Rami <rami.rosen@intel.com>
>>>> Subject: [dpdk-dev] [PATCH] net/i40e: Fix a typo in i40e_flow.c.
>>>>
>>>> This patch fixes a trivial typo in i40e_flow.c.
>>>>
>>>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>>>
>>> Acked-by: John McNamara <john.mcnamara@intel.com>
>>
>>     net/i40e: fix a typo in flow
>>
>>     Fixes: 47c6782344b7 ("net/i40e: fix tunnel filter")
>>     Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
>>     Cc: stable@dpdk.org
> 
> I think we don't have to put a (comment) typo fix patch into a stable
> release, though it does no harm.

This is to make it more visible to you, later you can pick it or not as
stable tree maintainer.

> 
> 	--yliu
>
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index c6e4d87..f163ce5 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -1309,7 +1309,7 @@  i40e_flow_parse_vxlan_pattern(const struct rte_flow_item *pattern,
 		case RTE_FLOW_ITEM_TYPE_IPV4:
 			filter->ip_type = RTE_TUNNEL_IPTYPE_IPV4;
 			/* IPv4 is used to describe protocol,
-			 * spec amd mask should be NULL.
+			 * spec and mask should be NULL.
 			 */
 			if (item->spec || item->mask) {
 				rte_flow_error_set(error, EINVAL,
@@ -1322,7 +1322,7 @@  i40e_flow_parse_vxlan_pattern(const struct rte_flow_item *pattern,
 		case RTE_FLOW_ITEM_TYPE_IPV6:
 			filter->ip_type = RTE_TUNNEL_IPTYPE_IPV6;
 			/* IPv6 is used to describe protocol,
-			 * spec amd mask should be NULL.
+			 * spec and mask should be NULL.
 			 */
 			if (item->spec || item->mask) {
 				rte_flow_error_set(error, EINVAL,
@@ -1334,7 +1334,7 @@  i40e_flow_parse_vxlan_pattern(const struct rte_flow_item *pattern,
 			break;
 		case RTE_FLOW_ITEM_TYPE_UDP:
 			/* UDP is used to describe protocol,
-			 * spec amd mask should be NULL.
+			 * spec and mask should be NULL.
 			 */
 			if (item->spec || item->mask) {
 				rte_flow_error_set(error, EINVAL,