diff mbox

[dpdk-dev,12/21] net/qede/base: fix DORQ attention mask

Message ID 1488181923-9649-12-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh Feb. 27, 2017, 7:51 a.m. UTC 
  Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/base/ecore_int.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit March 2, 2017, 1:06 p.m. UTC | #1 
On 2/27/2017 7:51 AM, Rasesh Mody wrote:
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

Please add Fixes line for all fixes.

Also it can be good to note in commit log what DORQ stands for.

> ---
<...>
diff mbox

Patch

diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c
index cb719a3..b6b8e2d 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b/drivers/net/qede/base/ecore_int.c
@@ -419,7 +419,7 @@  static enum _ecore_status_t ecore_fw_assertion(struct ecore_hwfn *p_hwfn)
 
 #define ECORE_DORQ_ATTENTION_REASON_MASK (0xfffff)
 #define ECORE_DORQ_ATTENTION_OPAQUE_MASK (0xffff)
-#define ECORE_DORQ_ATTENTION_SIZE_MASK	 (0x7f)
+#define ECORE_DORQ_ATTENTION_SIZE_MASK	 (0x7f0000)
 #define ECORE_DORQ_ATTENTION_SIZE_SHIFT	 (16)
 
 static enum _ecore_status_t ecore_dorq_attn_cb(struct ecore_hwfn *p_hwfn)