diff mbox

[dpdk-dev,18/21] net/qede/base: semantic fix

Message ID 1488181923-9649-18-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh Feb. 27, 2017, 7:52 a.m. UTC 
  No need to return - base on return at end of function.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/base/ecore_vf.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit March 2, 2017, 1:06 p.m. UTC | #1 
On 2/27/2017 7:52 AM, Rasesh Mody wrote:
> No need to return - base on return at end of function.

Does it make sense to update patch title to remove "fix" to prevent
misunderstanding, perhaps to something like: "refactor return path" or
"update semantic"

> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
<...>
diff mbox

Patch

diff --git a/drivers/net/qede/base/ecore_vf.c b/drivers/net/qede/base/ecore_vf.c
index 2b820b5..c12cbcf 100644
--- a/drivers/net/qede/base/ecore_vf.c
+++ b/drivers/net/qede/base/ecore_vf.c
@@ -126,7 +126,6 @@  static void ecore_vf_pf_req_end(struct ecore_hwfn *p_hwfn,
 			   "VF <-- PF Timeout [Type %d]\n",
 			   p_req->first_tlv.tl.type);
 		rc = ECORE_TIMEOUT;
-		return rc;
 	} else {
 		DP_VERBOSE(p_hwfn, ECORE_MSG_IOV,
 			   "PF response: %d [Type %d]\n",