[dpdk-dev,20/21] net/qede/base: fix the value of RESOURCE_DUMP to 0

Message ID 1488181923-9649-20-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh Feb. 27, 2017, 7:52 a.m. UTC
  Fix the value of RESOURCE_DUMP to 0

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/base/mcp_public.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit March 2, 2017, 1:07 p.m. UTC | #1
On 2/27/2017 7:52 AM, Rasesh Mody wrote:
> Fix the value of RESOURCE_DUMP to 0

Can you please update patch title to what really fixed,
is it something like:
"fix performance issues caused by resource dumping"

> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
<...>
  

Patch

diff --git a/drivers/net/qede/base/mcp_public.h b/drivers/net/qede/base/mcp_public.h
index 308b7fe..969dd5a 100644
--- a/drivers/net/qede/base/mcp_public.h
+++ b/drivers/net/qede/base/mcp_public.h
@@ -1238,7 +1238,7 @@  struct public_drv_mb {
 	#define RESOURCE_OPCODE_WRONG_OWNER		5
 	#define RESOURCE_OPCODE_UNKNOWN_CMD		255
 	/* dedicate resource 0 for dump */
-	#define RESOURCE_DUMP				(1 << 0)
+	#define RESOURCE_DUMP				0
 #define DRV_MSG_CODE_GET_MBA_VERSION		0x00240000 /* Get MBA version */
 /* Send crash dump commands with param[3:0] - opcode */
 #define DRV_MSG_CODE_MDUMP_CMD			0x00250000