diff mbox

[dpdk-dev] net/mlx5: fix a wrong error handler

Message ID 38bffaf86edf94efd9d271feb251460e46ef5597.1488270759.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nélio Laranjeiro Feb. 28, 2017, 8:33 a.m. UTC 
  The returned error code was wrongly handled causing the PMD to refuse to
start.

Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied")

CC: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit March 4, 2017, 12:05 a.m. UTC | #1 
On 2/28/2017 8:33 AM, Nelio Laranjeiro wrote:
> The returned error code was wrongly handled causing the PMD to refuse to
> start.
> 
> Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied")
> 
> CC: stable@dpdk.org
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Squashed into original commit "net/mlx5: fix startup when flow cannot be
applied"
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 683b57c..0acbf28 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -87,7 +87,7 @@  mlx5_dev_start(struct rte_eth_dev *dev)
 	if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_NONE)
 		priv_fdir_enable(priv);
 	err = priv_flow_start(priv);
-	if (!err) {
+	if (err) {
 		priv->started = 0;
 		ERROR("%p: an error occurred while configuring flows:"
 		      " %s",