diff mbox

[dpdk-dev,v2,3/3] lib/librte_ether: fix code style issues

Message ID 1488441084-6039-4-git-send-email-amis@radware.com (mailing list archive)
State Superseded, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ami Sabo March 2, 2017, 7:51 a.m. UTC 
  Fixed code style issues following Yuanhan Liu's review.

Signed-off-by: Ami Sabo <amis@radware.com>
---
 lib/librte_ether/rte_ethdev.h          | 2 +-
 lib/librte_ether/rte_ether_version.map | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Yuanhan Liu March 2, 2017, 8:12 a.m. UTC | #1 
On Thu, Mar 02, 2017 at 09:51:24AM +0200, Ami Sabo wrote:
> Fixed code style issues following Yuanhan Liu's review.

Patch 1 is not merged yet. You should squash this fix into patch 1,
instead of sending another patch.

Meanwhile, when you do so, you should add version log, and put it
at .....>

> 
> Signed-off-by: Ami Sabo <amis@radware.com>
> ---

... here (right below the ---). It could be something like:

- v2: fix coding style issues (Yuanhan Liu)


If you are still unsure, just find some examples from the mailing list.

	--yliu
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 9d5848b..6c9af46 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1766,7 +1766,7 @@  struct rte_eth_dev *rte_eth_dev_allocate(const char *name);
  * process.
  *
  * @param       name    Ethernet device's name.
-  @return
+ * @return
  *   - Success: Slot in the rte_dev_devices array for attached
  *        device.
  *   - Error: Null pointer.
diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
index d34c57a..28fb7d9 100644
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -156,8 +156,8 @@  DPDK_17.02 {
 } DPDK_16.11;
 
 DPDK_17.05 {
-        global:
+	global:
 
-        rte_eth_dev_attach_secondary;
+	rte_eth_dev_attach_secondary;
 
 } DPDK_17.02;