[dpdk-dev,v4,01/17] eventdev: increase size of enq deq conf variables
Checks
Commit Message
Large port enqueue sizes were not supported as the value
it was stored in was a uint8_t. Using uint8_ts to save
space in config apis makes no sense - increasing the 3
instances of uint8_t enqueue / dequeue depths to more
appropriate values (based on the context around them).
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_eventdev/rte_eventdev.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On Fri, Mar 10, 2017 at 07:43:16PM +0000, Harry van Haaren wrote:
> Large port enqueue sizes were not supported as the value
> it was stored in was a uint8_t. Using uint8_ts to save
> space in config apis makes no sense - increasing the 3
> instances of uint8_t enqueue / dequeue depths to more
> appropriate values (based on the context around them).
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied to dpdk-next-eventdev/master. Thanks.
> ---
> lib/librte_eventdev/rte_eventdev.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index e2fdf72..4876353 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -426,7 +426,7 @@ struct rte_event_dev_config {
> * This value cannot exceed the *max_event_queue_flows* which previously
> * provided in rte_event_dev_info_get()
> */
> - uint8_t nb_event_port_dequeue_depth;
> + uint32_t nb_event_port_dequeue_depth;
> /**< Maximum number of events can be dequeued at a time from an
> * event port by this device.
> * This value cannot exceed the *max_event_port_dequeue_depth*
> @@ -637,12 +637,12 @@ struct rte_event_port_conf {
> * which was previously supplied to rte_event_dev_configure().
> * This should be set to '-1' for *open system*.
> */
> - uint8_t dequeue_depth;
> + uint16_t dequeue_depth;
> /**< Configure number of bulk dequeues for this event port.
> * This value cannot exceed the *nb_event_port_dequeue_depth*
> * which previously supplied to rte_event_dev_configure()
> */
> - uint8_t enqueue_depth;
> + uint16_t enqueue_depth;
> /**< Configure number of bulk enqueues for this event port.
> * This value cannot exceed the *nb_event_port_enqueue_depth*
> * which previously supplied to rte_event_dev_configure()
> --
> 2.7.4
>
@@ -426,7 +426,7 @@ struct rte_event_dev_config {
* This value cannot exceed the *max_event_queue_flows* which previously
* provided in rte_event_dev_info_get()
*/
- uint8_t nb_event_port_dequeue_depth;
+ uint32_t nb_event_port_dequeue_depth;
/**< Maximum number of events can be dequeued at a time from an
* event port by this device.
* This value cannot exceed the *max_event_port_dequeue_depth*
@@ -637,12 +637,12 @@ struct rte_event_port_conf {
* which was previously supplied to rte_event_dev_configure().
* This should be set to '-1' for *open system*.
*/
- uint8_t dequeue_depth;
+ uint16_t dequeue_depth;
/**< Configure number of bulk dequeues for this event port.
* This value cannot exceed the *nb_event_port_dequeue_depth*
* which previously supplied to rte_event_dev_configure()
*/
- uint8_t enqueue_depth;
+ uint16_t enqueue_depth;
/**< Configure number of bulk enqueues for this event port.
* This value cannot exceed the *nb_event_port_enqueue_depth*
* which previously supplied to rte_event_dev_configure()