[dpdk-dev,v2,1/2] eal/linux: support external Rx interrupt
Checks
Commit Message
Prior to this patch only UIO/VFIO interrupt handlers types were supported.
This patch adds support for the external interrupt handler type, allowing
external drivers to set their own fds with specific interrupt handlers.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 33 ++++++++++++++--------
.../linuxapp/eal/include/exec-env/rte_interrupts.h | 9 ++++++
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++
3 files changed, 37 insertions(+), 12 deletions(-)
Comments
> On Mar 14, 2017, at 6:03 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>
> Prior to this patch only UIO/VFIO interrupt handlers types were supported.
> This patch adds support for the external interrupt handler type, allowing
> external drivers to set their own fds with specific interrupt handlers.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Regards,
Yongseok
On 3/14/2017 4:38 PM, Yongseok Koh wrote:
>
>> On Mar 14, 2017, at 6:03 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>>
>> Prior to this patch only UIO/VFIO interrupt handlers types were supported.
>> This patch adds support for the external interrupt handler type, allowing
>> external drivers to set their own fds with specific interrupt handlers.
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Series applied to dpdk-next-net/master, thanks.
@@ -939,6 +939,8 @@ static __attribute__((noreturn)) void *
bytes_read = sizeof(buf.vfio_intr_count);
break;
#endif
+ case RTE_INTR_HANDLE_EXT:
+ return;
default:
bytes_read = 1;
RTE_LOG(INFO, EAL, "unexpected intr type\n");
@@ -1167,6 +1169,24 @@ static __attribute__((noreturn)) void *
return rc;
}
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+ uint32_t i;
+ struct rte_epoll_event *rev;
+
+ for (i = 0; i < intr_handle->nb_efd; i++) {
+ rev = &intr_handle->elist[i];
+ if (rev->status == RTE_EPOLL_INVALID)
+ continue;
+ if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
+ /* force free if the entry valid */
+ eal_epoll_data_safe_free(rev);
+ rev->status = RTE_EPOLL_INVALID;
+ }
+ }
+}
+
int
rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd)
{
@@ -1202,19 +1222,8 @@ static __attribute__((noreturn)) void *
rte_intr_efd_disable(struct rte_intr_handle *intr_handle)
{
uint32_t i;
- struct rte_epoll_event *rev;
-
- for (i = 0; i < intr_handle->nb_efd; i++) {
- rev = &intr_handle->elist[i];
- if (rev->status == RTE_EPOLL_INVALID)
- continue;
- if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
- /* force free if the entry valid */
- eal_epoll_data_safe_free(rev);
- rev->status = RTE_EPOLL_INVALID;
- }
- }
+ rte_intr_free_epoll_fd(intr_handle);
if (intr_handle->max_intr > intr_handle->nb_efd) {
for (i = 0; i < intr_handle->nb_efd; i++)
close(intr_handle->efds[i]);
@@ -171,6 +171,15 @@ struct rte_intr_handle {
int epfd, int op, unsigned int vec, void *data);
/**
+ * It deletes registered eventfds.
+ *
+ * @param intr_handle
+ * Pointer to the interrupt handle.
+ */
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle);
+
+/**
* It enables the packet I/O interrupt event if it's necessary.
* It creates event fd for each interrupt vector when MSIX is used,
* otherwise it multiplexes a single event fd.
@@ -186,3 +186,10 @@ DPDK_17.02 {
rte_bus_unregister;
} DPDK_16.11;
+
+DPDK_17.05 {
+ global:
+
+ rte_intr_free_epoll_fd;
+
+} DPDK_17.02;