diff mbox

[dpdk-dev] mk: remove invalid phony target

Message ID 1489770533-25754-1-git-send-email-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Olivier Matz March 17, 2017, 5:08 p.m. UTC 
  There was a typo in the .PHONY for the test-build target. If we fix the
typo, the test-build target does not work, because it won't match the
'%' target anymore.

So just remove the .PHONY.

Fixes: 64592d97c1ae ("mk: do not build tests by default")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 mk/rte.sdkroot.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit March 20, 2017, 11:34 a.m. UTC | #1 
On 3/17/2017 5:08 PM, Olivier Matz wrote:
> There was a typo in the .PHONY for the test-build target. If we fix the
> typo, the test-build target does not work, because it won't match the
> '%' target anymore.
> 
> So just remove the .PHONY.
> 
> Fixes: 64592d97c1ae ("mk: do not build tests by default")
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon March 27, 2017, 8:43 a.m. UTC | #2 
2017-03-20 11:34, Ferruh Yigit:
> On 3/17/2017 5:08 PM, Olivier Matz wrote:
> > There was a typo in the .PHONY for the test-build target. If we fix the
> > typo, the test-build target does not work, because it won't match the
> > '%' target anymore.
> > 
> > So just remove the .PHONY.
> > 
> > Fixes: 64592d97c1ae ("mk: do not build tests by default")
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index 7598bde..f20563e 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -96,7 +96,6 @@  config showconfigs showversion showversionum:
 test test-basic test-fast test-ring test-mempool test-perf coverage:
 	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
 
-.PHONY: test-buid
 test: test-build
 
 .PHONY: install