[dpdk-dev] net/sfc: fix always fail Tx queue setup with VLAN offload

Message ID 1490177016-13651-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Andrew Rybchenko March 22, 2017, 10:03 a.m. UTC
  Fixes: 1eb4d2e4b360 ("net/sfc: make VLAN insertion a datapath-dependent feature")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
It would be good if the fix is squashed into corresponding patch.

 drivers/net/sfc/sfc_tx.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Ferruh Yigit March 22, 2017, 10:57 a.m. UTC | #1
On 3/22/2017 10:03 AM, Andrew Rybchenko wrote:
> Fixes: 1eb4d2e4b360 ("net/sfc: make VLAN insertion a datapath-dependent feature")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> It would be good if the fix is squashed into corresponding patch.

Done, squashed into 1eb4d2e4b360
  

Patch

diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c
index 0c8ff26..e7ec802 100644
--- a/drivers/net/sfc/sfc_tx.c
+++ b/drivers/net/sfc/sfc_tx.c
@@ -101,7 +101,6 @@  sfc_tx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_tx_desc,
 				sa->dp_tx->dp.name);
 			rc = EINVAL;
 		}
-		rc = EINVAL;
 	}
 
 	if ((flags & ETH_TXQ_FLAGS_NOXSUMSCTP) == 0) {