diff mbox

[dpdk-dev,1/1] net/cxgbe: check return value of malloc

Message ID	453363AE6316CC428D594009B784F9050335F159@SZXEMI508-MBS.china.huawei.com (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: caihe <caihe@huawei.com> To: "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com> CC: "dev@dpdk.org" <dev@dpdk.org>, wangyunjian <wangyunjian@huawei.com>, "Lilijun (Jerry)" <jerry.lilijun@huawei.com>, Zhoujingbin <zhoujingbin@huawei.com> Thread-Topic: [dpdk-dev] [PATCH 1/1] net/cxgbe: check return value of malloc Thread-Index: AdKlZQTDB7hYyAo0R6eXXo5rCXuedw== Date: Sat, 25 Mar 2017 12:44:29 +0000 Message-ID: <453363AE6316CC428D594009B784F9050335F159@SZXEMI508-MBS.china.huawei.com> Accept-Language: en-US Content-Language: zh-CN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/1] net/cxgbe: check return value of malloc Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues
ci/Intel-compilation	fail	apply patch file failure

Commit Message

caihe March 25, 2017, 12:44 p.m. UTC

  Hi rahul,

There is a bug without check the return value of alloc memory in function t4_wr_mbox_meat_timeout, if we should fix it as below:


Best Regards

Comments

Rahul Lakkireddy March 27, 2017, 7:35 a.m. UTC | #1

On Saturday, March 03/25/17, 2017 at 18:14:29 +0530, caihe wrote:
>    Hi rahul,
> 
>    There is a bug without check the return value of alloc memory in function
>    t4_wr_mbox_meat_timeout, if we should fix it as below:
> 
>    diff --git a/drivers/net/cxgbe/base/t4_hw.c
>    b/drivers/net/cxgbe/base/t4_hw.c
>    index c089b06..7402a5f 100644
>    --- a/drivers/net/cxgbe/base/t4_hw.c
>    +++ b/drivers/net/cxgbe/base/t4_hw.c
>    @@ -359,6 +359,10 @@ int t4_wr_mbox_meat_timeout(struct adapter *adap, int
>    mbox,
>            struct mbox_entry entry;
>            u32 pcie_fw = 0;
>     
>    +       if (!temp) {
>    +               return -ENOMEM;
>    +       }
>    +
>            if ((size & 15) || size > MBOX_LEN) {
>                    free(temp);
>                    return -EINVAL;
> 
>    Best Regards

Thanks for the fix!  However, there seem to be checkpatch issues with
the patch that need to be fixed.

http://dpdk.org/ml/archives/test-report/2017-March/015606.html

Thanks,
Rahul

diff mbox

Patch

diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
index c089b06..7402a5f 100644
--- a/drivers/net/cxgbe/base/t4_hw.c
+++ b/drivers/net/cxgbe/base/t4_hw.c
@@ -359,6 +359,10 @@  int t4_wr_mbox_meat_timeout(struct adapter *adap, int mbox,
        struct mbox_entry entry;
        u32 pcie_fw = 0;
 
+       if (!temp) {
+               return -ENOMEM;
+       }
+
        if ((size & 15) || size > MBOX_LEN) {
                free(temp);
                return -EINVAL;