[dpdk-dev] bug in LPM handling (16.04+)
Checks
Commit Message
Comments
On Wed, Mar 29, 2017 at 02:38:13PM +0200, László Molnár wrote:
> --- rte_lpm.c~3 2017-03-29 12:19:06.146933973 +0200
> +++ rte_lpm.c 2017-03-29 12:19:06.000000000 +0200
> @@ -1034,7 +1034,7 @@
> */
>
> struct rte_lpm_tbl_entry new_tbl24_entry = {
> - .group_idx = (uint8_t)tbl8_group_index,
> + .group_idx = tbl8_group_index,
> .valid = VALID,
> .valid_group = 1,
> .depth = 0,
> @@ -1080,7 +1080,7 @@
> */
>
> struct rte_lpm_tbl_entry new_tbl24_entry = {
> - .group_idx = (uint8_t)tbl8_group_index,
> + .group_idx = tbl8_group_index,
> .valid = VALID,
> .valid_group = 1,
> .depth = 0,
>
Hi,
this fix looks reasonable. Can you perhaps resend as a proper patch with
signoff, as described in contributors guide doc? See:
http://dpdk.org/doc/guides/contributing/patches.html#make-your-changes
Thanks,
/Bruce
@@ -1034,7 +1034,7 @@
*/
struct rte_lpm_tbl_entry new_tbl24_entry = {
- .group_idx = (uint8_t)tbl8_group_index,
+ .group_idx = tbl8_group_index,
.valid = VALID,
.valid_group = 1,
.depth = 0,
@@ -1080,7 +1080,7 @@
*/
struct rte_lpm_tbl_entry new_tbl24_entry = {
- .group_idx = (uint8_t)tbl8_group_index,
+ .group_idx = tbl8_group_index,
.valid = VALID,
.valid_group = 1,
.depth = 0,