[dpdk-dev] crypto/aesni-mb: support IPSec Multi-buffer lib v0.45

Message ID 1490886258-146378-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

De Lara Guarch, Pablo March 30, 2017, 3:04 p.m. UTC
  IPSec Multi-buffer library v0.45 has been released,
which includes, among other features, support for DOCSIS BPI
specification and include AVX512 optimizations.

This new version added const qualifiers to some of the function
prototypes, so the PMD has been updated to include these changes.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/cryptodevs/aesni_mb.rst         |  4 ++--
 drivers/crypto/aesni_mb/aesni_mb_ops.h     | 20 ++++++++++----------
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c |  4 ++--
 3 files changed, 14 insertions(+), 14 deletions(-)
  

Comments

Doherty, Declan March 30, 2017, 3:31 p.m. UTC | #1
On 30/03/2017 4:04 PM, Pablo de Lara wrote:
> IPSec Multi-buffer library v0.45 has been released,
> which includes, among other features, support for DOCSIS BPI
> specification and include AVX512 optimizations.
>
> This new version added const qualifiers to some of the function
> prototypes, so the PMD has been updated to include these changes.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
...
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
  
De Lara Guarch, Pablo March 30, 2017, 3:58 p.m. UTC | #2
> -----Original Message-----
> From: Doherty, Declan
> Sent: Thursday, March 30, 2017 4:31 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] crypto/aesni-mb: support IPSec Multi-buffer lib v0.45
> 
> On 30/03/2017 4:04 PM, Pablo de Lara wrote:
> > IPSec Multi-buffer library v0.45 has been released,
> > which includes, among other features, support for DOCSIS BPI
> > specification and include AVX512 optimizations.
> >
> > This new version added const qualifiers to some of the function
> > prototypes, so the PMD has been updated to include these changes.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> ...
> >
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-crypto.

Pablo
  

Patch

diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst
index d61d9e4..4b3b170 100644
--- a/doc/guides/cryptodevs/aesni_mb.rst
+++ b/doc/guides/cryptodevs/aesni_mb.rst
@@ -73,8 +73,8 @@  Installation
 To build DPDK with the AESNI_MB_PMD the user is required to download the multi-buffer
 library from `here <https://github.com/01org/intel-ipsec-mb>`_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v0.44, which
-can be downloaded in `<https://github.com/01org/intel-ipsec-mb/archive/v0.44.zip>`_.
+The latest version of the library supported by this PMD is v0.45, which
+can be downloaded in `<https://github.com/01org/intel-ipsec-mb/archive/v0.45.zip>`_.
 
 .. code-block:: console
 
diff --git a/drivers/crypto/aesni_mb/aesni_mb_ops.h b/drivers/crypto/aesni_mb/aesni_mb_ops.h
index 2d41d73..d4dc4f2 100644
--- a/drivers/crypto/aesni_mb/aesni_mb_ops.h
+++ b/drivers/crypto/aesni_mb/aesni_mb_ops.h
@@ -48,23 +48,23 @@  enum aesni_mb_vector_mode {
 	RTE_AESNI_MB_AVX512
 };
 
-typedef void (*md5_one_block_t)(void *data, void *digest);
+typedef void (*md5_one_block_t)(const void *data, void *digest);
 
-typedef void (*sha1_one_block_t)(void *data, void *digest);
-typedef void (*sha224_one_block_t)(void *data, void *digest);
-typedef void (*sha256_one_block_t)(void *data, void *digest);
-typedef void (*sha384_one_block_t)(void *data, void *digest);
-typedef void (*sha512_one_block_t)(void *data, void *digest);
+typedef void (*sha1_one_block_t)(const void *data, void *digest);
+typedef void (*sha224_one_block_t)(const void *data, void *digest);
+typedef void (*sha256_one_block_t)(const void *data, void *digest);
+typedef void (*sha384_one_block_t)(const void *data, void *digest);
+typedef void (*sha512_one_block_t)(const void *data, void *digest);
 
 typedef void (*aes_keyexp_128_t)
-		(void *key, void *enc_exp_keys, void *dec_exp_keys);
+		(const void *key, void *enc_exp_keys, void *dec_exp_keys);
 typedef void (*aes_keyexp_192_t)
-		(void *key, void *enc_exp_keys, void *dec_exp_keys);
+		(const void *key, void *enc_exp_keys, void *dec_exp_keys);
 typedef void (*aes_keyexp_256_t)
-		(void *key, void *enc_exp_keys, void *dec_exp_keys);
+		(const void *key, void *enc_exp_keys, void *dec_exp_keys);
 
 typedef void (*aes_xcbc_expand_key_t)
-		(void *key, void *exp_k1, void *k2, void *k3);
+		(const void *key, void *exp_k1, void *k2, void *k3);
 
 /** Multi-buffer library function pointer table */
 struct aesni_mb_ops {
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
index 432d239..c448811 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
@@ -40,8 +40,8 @@ 
 
 #include "rte_aesni_mb_pmd_private.h"
 
-typedef void (*hash_one_block_t)(void *data, void *digest);
-typedef void (*aes_keyexp_t)(void *key, void *enc_exp_keys, void *dec_exp_keys);
+typedef void (*hash_one_block_t)(const void *data, void *digest);
+typedef void (*aes_keyexp_t)(const void *key, void *enc_exp_keys, void *dec_exp_keys);
 
 /**
  * Calculate the authentication pre-computes