diff mbox

[dpdk-dev,v2,1/2] app/testpmd: change command line of loading profile

Message ID 1491033428-68635-2-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei April 1, 2017, 7:57 a.m. UTC 
  This patch changes CLI of loading profile from
"add ddp (port_id) (profile_path)" to "ddp add
(port_id) (profile_path)" which is more consistent
with other CLIs.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/cmdline.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

Comments

Wenzhuo Lu April 1, 2017, 8:23 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Saturday, April 1, 2017 3:57 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 1/2] app/testpmd: change command line of
> loading profile
> 
> This patch changes CLI of loading profile from "add ddp (port_id)
> (profile_path)" to "ddp add
> (port_id) (profile_path)" which is more consistent with other CLIs.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Ferruh Yigit April 3, 2017, 12:30 p.m. UTC | #2 
On 4/1/2017 8:57 AM, Beilei Xing wrote:
> This patch changes CLI of loading profile from
> "add ddp (port_id) (profile_path)" to "ddp add
> (port_id) (profile_path)" which is more consistent
> with other CLIs.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Series squashed into relevant commit in next-net, thanks.

(Please double check updated commits.)
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index aac4efb..3a448b3 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -593,7 +593,7 @@  static void cmd_help_long_parsed(void *parsed_result,
 			"E-tag set filter del e-tag-id (value) port (port_id)\n"
 			"    Delete an E-tag forwarding filter on a port\n\n"
 
-			"add ddp (port_id) (profile_path)\n"
+			"ddp add (port_id) (profile_path)\n"
 			"    Load a profile package on a port\n\n"
 
 			, list_pkt_forwarding_modes()
@@ -12746,29 +12746,29 @@  cmdline_parse_inst_t cmd_strict_link_prio = {
 };
 
 /* Load dynamic device personalization*/
-struct cmd_add_ddp_result {
-	cmdline_fixed_string_t add;
+struct cmd_ddp_add_result {
 	cmdline_fixed_string_t ddp;
+	cmdline_fixed_string_t add;
 	uint8_t port_id;
 	char filepath[];
 };
 
-cmdline_parse_token_string_t cmd_add_ddp_add =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, add, "add");
-cmdline_parse_token_string_t cmd_add_ddp_ddp =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, ddp, "ddp");
-cmdline_parse_token_num_t cmd_add_ddp_port_id =
-	TOKEN_NUM_INITIALIZER(struct cmd_add_ddp_result, port_id, UINT8);
-cmdline_parse_token_string_t cmd_add_ddp_filepath =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, filepath, NULL);
+cmdline_parse_token_string_t cmd_ddp_add_ddp =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, ddp, "ddp");
+cmdline_parse_token_string_t cmd_ddp_add_add =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, add, "add");
+cmdline_parse_token_num_t cmd_ddp_add_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_ddp_add_result, port_id, UINT8);
+cmdline_parse_token_string_t cmd_ddp_add_filepath =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, filepath, NULL);
 
 static void
-cmd_add_ddp_parsed(
+cmd_ddp_add_parsed(
 	void *parsed_result,
 	__attribute__((unused)) struct cmdline *cl,
 	__attribute__((unused)) void *data)
 {
-	struct cmd_add_ddp_result *res = parsed_result;
+	struct cmd_ddp_add_result *res = parsed_result;
 	uint8_t *buff;
 	uint32_t size;
 	int ret = -ENOTSUP;
@@ -12802,15 +12802,15 @@  cmd_add_ddp_parsed(
 	close_ddp_package_file(buff);
 }
 
-cmdline_parse_inst_t cmd_add_ddp = {
-	.f = cmd_add_ddp_parsed,
+cmdline_parse_inst_t cmd_ddp_add = {
+	.f = cmd_ddp_add_parsed,
 	.data = NULL,
-	.help_str = "add/remove ddp <port_id> <profile_path>",
+	.help_str = "ddp add <port_id> <profile_path>",
 	.tokens = {
-		(void *)&cmd_add_ddp_add,
-		(void *)&cmd_add_ddp_ddp,
-		(void *)&cmd_add_ddp_port_id,
-		(void *)&cmd_add_ddp_filepath,
+		(void *)&cmd_ddp_add_ddp,
+		(void *)&cmd_ddp_add_add,
+		(void *)&cmd_ddp_add_port_id,
+		(void *)&cmd_ddp_add_filepath,
 		NULL,
 	},
 };
@@ -13081,7 +13081,7 @@  cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_vf_tc_min_bw,
 	(cmdline_parse_inst_t *)&cmd_vf_tc_max_bw,
 	(cmdline_parse_inst_t *)&cmd_strict_link_prio,
-	(cmdline_parse_inst_t *)&cmd_add_ddp,
+	(cmdline_parse_inst_t *)&cmd_ddp_add,
 	(cmdline_parse_inst_t *)&cmd_get_ddp_list,
 	NULL,
 };