[dpdk-dev,v2,2/2] app/testpmd: change command line of getting profile info

Message ID 1491033428-68635-3-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei April 1, 2017, 7:57 a.m. UTC
  This patch changes CLI of getting loaded profile
info list from "get ddp list (port_id)" to "ddp
get list (port_id)" which is more consistent with
other CLIs.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/cmdline.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)
  

Comments

Wenzhuo Lu April 1, 2017, 8:23 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Saturday, April 1, 2017 3:57 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: change command line of
> getting profile info
> 
> This patch changes CLI of getting loaded profile info list from "get ddp list
> (port_id)" to "ddp get list (port_id)" which is more consistent with other CLIs.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
  

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3a448b3..66cd09a 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -215,7 +215,7 @@  static void cmd_help_long_parsed(void *parsed_result,
 			"read txd (port_id) (queue_id) (txd_id)\n"
 			"    Display a TX descriptor of a port TX queue.\n\n"
 
-			"get ddp list (port_id)\n"
+			"ddp get list (port_id)\n"
 			"    Get ddp profile info list\n\n"
 		);
 	}
@@ -12819,29 +12819,29 @@  cmdline_parse_inst_t cmd_ddp_add = {
 #define PROFILE_INFO_SIZE 48
 #define MAX_PROFILE_NUM 16
 
-struct cmd_get_ddp_list_result {
-	cmdline_fixed_string_t get;
+struct cmd_ddp_get_list_result {
 	cmdline_fixed_string_t ddp;
+	cmdline_fixed_string_t get;
 	cmdline_fixed_string_t list;
 	uint8_t port_id;
 };
 
-cmdline_parse_token_string_t cmd_get_ddp_list_get =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, get, "get");
-cmdline_parse_token_string_t cmd_get_ddp_list_ddp =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, ddp, "ddp");
-cmdline_parse_token_string_t cmd_get_ddp_list_list =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, list, "list");
-cmdline_parse_token_num_t cmd_get_ddp_list_port_id =
-	TOKEN_NUM_INITIALIZER(struct cmd_get_ddp_list_result, port_id, UINT8);
+cmdline_parse_token_string_t cmd_ddp_get_list_ddp =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, ddp, "ddp");
+cmdline_parse_token_string_t cmd_ddp_get_list_get =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, get, "get");
+cmdline_parse_token_string_t cmd_ddp_get_list_list =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, list, "list");
+cmdline_parse_token_num_t cmd_ddp_get_list_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_ddp_get_list_result, port_id, UINT8);
 
 static void
-cmd_get_ddp_list_parsed(
+cmd_ddp_get_list_parsed(
 	void *parsed_result,
 	__attribute__((unused)) struct cmdline *cl,
 	__attribute__((unused)) void *data)
 {
-	struct cmd_get_ddp_list_result *res = parsed_result;
+	struct cmd_ddp_get_list_result *res = parsed_result;
 #ifdef RTE_LIBRTE_I40E_PMD
 	struct rte_pmd_i40e_profile_list *p_list;
 	struct rte_pmd_i40e_profile_info *p_info;
@@ -12890,15 +12890,15 @@  cmd_get_ddp_list_parsed(
 		printf("Failed to get ddp list\n");
 }
 
-cmdline_parse_inst_t cmd_get_ddp_list = {
-	.f = cmd_get_ddp_list_parsed,
+cmdline_parse_inst_t cmd_ddp_get_list = {
+	.f = cmd_ddp_get_list_parsed,
 	.data = NULL,
-	.help_str = "get ddp list <port_id>",
+	.help_str = "ddp get list <port_id>",
 	.tokens = {
-		(void *)&cmd_get_ddp_list_get,
-		(void *)&cmd_get_ddp_list_ddp,
-		(void *)&cmd_get_ddp_list_list,
-		(void *)&cmd_get_ddp_list_port_id,
+		(void *)&cmd_ddp_get_list_ddp,
+		(void *)&cmd_ddp_get_list_get,
+		(void *)&cmd_ddp_get_list_list,
+		(void *)&cmd_ddp_get_list_port_id,
 		NULL,
 	},
 };
@@ -13082,7 +13082,7 @@  cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_vf_tc_max_bw,
 	(cmdline_parse_inst_t *)&cmd_strict_link_prio,
 	(cmdline_parse_inst_t *)&cmd_ddp_add,
-	(cmdline_parse_inst_t *)&cmd_get_ddp_list,
+	(cmdline_parse_inst_t *)&cmd_ddp_get_list,
 	NULL,
 };