[dpdk-dev,v2] cryptodev: add API note

Message ID 1491234693-14494-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Fiona Trahe April 3, 2017, 3:51 p.m. UTC
  Add note to cryptodev API that chained mbufs
are not supported in DOCSISBPI mode.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
v2 changes:
 - moved the comment from the rte_crypto_sym_op to the algorithm enum

 lib/librte_cryptodev/rte_crypto_sym.h | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Doherty, Declan April 4, 2017, 9:07 a.m. UTC | #1
On 03/04/2017 4:51 PM, Fiona Trahe wrote:
> Add note to cryptodev API that chained mbufs
> are not supported in DOCSISBPI mode.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
...
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
  
De Lara Guarch, Pablo April 4, 2017, 9:48 a.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Tuesday, April 04, 2017 10:08 AM
> To: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: add API note
> 
> On 03/04/2017 4:51 PM, Fiona Trahe wrote:
> > Add note to cryptodev API that chained mbufs
> > are not supported in DOCSISBPI mode.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> ...
> >
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
  

Patch

diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index 4d5459f..508f4ee 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -111,11 +111,15 @@  enum rte_crypto_cipher_algorithm {
 	RTE_CRYPTO_CIPHER_AES_DOCSISBPI,
 	/**< AES algorithm using modes required by
 	 * DOCSIS Baseline Privacy Plus Spec.
+	 * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
+	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
 
 	RTE_CRYPTO_CIPHER_DES_DOCSISBPI,
 	/**< DES algorithm using modes required by
 	 * DOCSIS Baseline Privacy Plus Spec.
+	 * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
+	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
 
 	RTE_CRYPTO_CIPHER_LIST_END