[dpdk-dev,v3] crypto/scheduler: fix session free

Message ID 1491298268-119128-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Fan Zhang April 4, 2017, 9:31 a.m. UTC
  This patch fixes the incorrection slave session free operation.

Fixes: 57523e682bb7 ("crypto/scheduler: register operation functions")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---

v3:
- Fixed incorrect removal in v2

v2:
- Removed unnecessary session set line.

 drivers/crypto/scheduler/scheduler_pmd_ops.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
  

Comments

De Lara Guarch, Pablo April 4, 2017, 3:27 p.m. UTC | #1
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, April 04, 2017 10:31 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.org
> Subject: [PATCH v3] crypto/scheduler: fix session free
> 
> This patch fixes the incorrection slave session free operation.
> 
> Fixes: 57523e682bb7 ("crypto/scheduler: register operation functions")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---

Acked and applied to dpdk-next-crypto.

Thanks,
Pablo
  

Patch

diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c
index f02506c..a13de46 100644
--- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
+++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
@@ -433,9 +433,8 @@  config_slave_sess(struct scheduler_ctx *sched_ctx,
 			if (create)
 				continue;
 			/* !create */
-			(*dev->dev_ops->session_clear)(dev,
-					(void *)sess->sessions[i]);
-			sess->sessions[i] = NULL;
+			sess->sessions[i] = rte_cryptodev_sym_session_free(
+					slave->dev_id, sess->sessions[i]);
 		} else {
 			if (!create)
 				continue;