[dpdk-dev] doc: add missing step in PVP reference benchmark howto

Message ID 20170405122833.3385-1-jfreiman@redhat.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jens Freimann April 5, 2017, 12:28 p.m. UTC
  After we configure QEMU we also need to call 'make' to build the binary.
This step is currently missing in the description and this patch fixes
it.

Signed-off-by: Jens Freimann <jfreiman@redhat.com>
---
 doc/guides/howto/pvp_reference_benchmark.rst | 1 +
 1 file changed, 1 insertion(+)
  

Comments

John McNamara April 5, 2017, 1:09 p.m. UTC | #1
> -----Original Message-----
> From: Jens Freimann [mailto:jfreiman@redhat.com]
> Sent: Wednesday, April 5, 2017 1:29 PM
> To: maxime.coquelin@redhat.com
> Cc: Mcnamara, John <john.mcnamara@intel.com>; dev@dpdk.org
> Subject: [PATCH] doc: add missing step in PVP reference benchmark howto
> 
> After we configure QEMU we also need to call 'make' to build the binary.
> This step is currently missing in the description and this patch fixes it.
> 
> Signed-off-by: Jens Freimann <jfreiman@redhat.com>


Thanks for the catch.

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Thomas Monjalon April 5, 2017, 1:23 p.m. UTC | #2
2017-04-05 13:09, Mcnamara, John:
> From: Jens Freimann [mailto:jfreiman@redhat.com]
> > 
> > After we configure QEMU we also need to call 'make' to build the binary.
> > This step is currently missing in the description and this patch fixes it.
> > 
> > Signed-off-by: Jens Freimann <jfreiman@redhat.com>
> 
> 
> Thanks for the catch.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/howto/pvp_reference_benchmark.rst b/doc/guides/howto/pvp_reference_benchmark.rst
index ace8e6f..6d514ff 100644
--- a/doc/guides/howto/pvp_reference_benchmark.rst
+++ b/doc/guides/howto/pvp_reference_benchmark.rst
@@ -119,6 +119,7 @@  Build Qemu:
        mkdir bin
        cd bin
        ../configure --target-list=x86_64-softmmu
+       make
 
 
 DPDK build