[dpdk-dev] doc: fix build error in DPAA2 PMD guide

Message ID 1491800074-24710-1-git-send-email-shreyansh.jain@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shreyansh Jain April 10, 2017, 4:54 a.m. UTC
  Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 doc/guides/nics/dpaa2.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

John McNamara April 10, 2017, 7:46 a.m. UTC | #1
> -----Original Message-----
> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
> Sent: Monday, April 10, 2017 5:55 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Shreyansh Jain
> <shreyansh.jain@nxp.com>
> Subject: [PATCH] doc: fix build error in DPAA2 PMD guide
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Ferruh Yigit April 11, 2017, 2:58 p.m. UTC | #2
On 4/10/2017 5:54 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>  doc/guides/nics/dpaa2.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst
> index 7d7a6c5..46225b6 100644
> --- a/doc/guides/nics/dpaa2.rst
> +++ b/doc/guides/nics/dpaa2.rst
> @@ -441,8 +441,7 @@ compatible board:
>  
>  1. **ARM 64 Tool Chain**
>  
> -   For example, the *aarch64* Linaro Toolchain, which can be obtained from
> -   `here <https://releases.linaro.org/components/toolchain/binaries/4.9-2017.01/aarch64-linux-gnu>`_.
> +   For example, the `*aarch64* Linaro Toolchain <https://releases.linaro.org/components/toolchain/binaries/4.9-2017.01/aarch64-linux-gnu>`_.

I think this is no more valid with v12 of PMD [1], removing from patchwork.

[1]
http://dpdk.org/dev/patchwork/patch/23484/

>  
>  2. **Linux Kernel**
>  
>
  
Shreyansh Jain April 11, 2017, 5:13 p.m. UTC | #3
Hi Ferruh,

> -----Original Message-----

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]

> Sent: Tuesday, April 11, 2017 8:28 PM

> To: Shreyansh Jain <shreyansh.jain@nxp.com>; Hemant Agrawal

> <hemant.agrawal@nxp.com>

> Cc: dev@dpdk.org; john.mcnamara@intel.com

> Subject: Re: [dpdk-dev] [PATCH] doc: fix build error in DPAA2 PMD guide

> 

> On 4/10/2017 5:54 AM, Shreyansh Jain wrote:

> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

> > ---

> >  doc/guides/nics/dpaa2.rst | 3 +--

> >  1 file changed, 1 insertion(+), 2 deletions(-)

> >

> > diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst

> > index 7d7a6c5..46225b6 100644

> > --- a/doc/guides/nics/dpaa2.rst

> > +++ b/doc/guides/nics/dpaa2.rst

> > @@ -441,8 +441,7 @@ compatible board:

> >

> >  1. **ARM 64 Tool Chain**

> >

> > -   For example, the *aarch64* Linaro Toolchain, which can be obtained from

> > -   `here <https://releases.linaro.org/components/toolchain/binaries/4.9-

> 2017.01/aarch64-linux-gnu>`_.

> > +   For example, the `*aarch64* Linaro Toolchain

> <https://releases.linaro.org/components/toolchain/binaries/4.9-

> 2017.01/aarch64-linux-gnu>`_.

> 

> I think this is no more valid with v12 of PMD [1], removing from patchwork.

 
Yes, that is already integrated now.
Thanks for removing from patchwork - it skipped my mind.

> 

> [1]

> http://dpdk.org/dev/patchwork/patch/23484/

> 

> >

> >  2. **Linux Kernel**

> >

> >
  

Patch

diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst
index 7d7a6c5..46225b6 100644
--- a/doc/guides/nics/dpaa2.rst
+++ b/doc/guides/nics/dpaa2.rst
@@ -441,8 +441,7 @@  compatible board:
 
 1. **ARM 64 Tool Chain**
 
-   For example, the *aarch64* Linaro Toolchain, which can be obtained from
-   `here <https://releases.linaro.org/components/toolchain/binaries/4.9-2017.01/aarch64-linux-gnu>`_.
+   For example, the `*aarch64* Linaro Toolchain <https://releases.linaro.org/components/toolchain/binaries/4.9-2017.01/aarch64-linux-gnu>`_.
 
 2. **Linux Kernel**