[dpdk-dev] mk: fix quoting for ARM mtune argument
Checks
Commit Message
The mtune argument needs an unquoted argument, otherwise the compiler
complains:
arm-buildroot-linux-gnueabi-gcc.br_real: error:
unrecognized argument in option ‘-mtune="cortex-a9"’
Fixes: 02a8686263de ("mk: introduce ARMv7 architecture")
Fixes: 4a7e4626975a ("mk: introduce NXP dpaa2 architecture based on armv8-a")
Reported-by: Jan Viktorin <viktorin@rehivetech.com>
Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
---
I couldn't test it though, as I don't have an ARM toolchain.
mk/machine/armv7a/rte.vars.mk | 2 +-
mk/machine/dpaa2/rte.vars.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On Mon, 10 Apr 2017 14:18:51 +0200
Pascal Mazon <pascal.mazon@6wind.com> wrote:
> The mtune argument needs an unquoted argument, otherwise the compiler
> complains:
>
> arm-buildroot-linux-gnueabi-gcc.br_real: error:
> unrecognized argument in option ‘-mtune="cortex-a9"’
>
> Fixes: 02a8686263de ("mk: introduce ARMv7 architecture")
> Fixes: 4a7e4626975a ("mk: introduce NXP dpaa2 architecture based on armv8-a")
>
> Reported-by: Jan Viktorin <viktorin@rehivetech.com>
> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
Tested-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>
> I couldn't test it though, as I don't have an ARM toolchain.
It works for me.
Jan
2017-04-10 14:28, Jan Viktorin:
> On Mon, 10 Apr 2017 14:18:51 +0200
> Pascal Mazon <pascal.mazon@6wind.com> wrote:
>
> > The mtune argument needs an unquoted argument, otherwise the compiler
> > complains:
> >
> > arm-buildroot-linux-gnueabi-gcc.br_real: error:
> > unrecognized argument in option ‘-mtune="cortex-a9"’
> >
> > Fixes: 02a8686263de ("mk: introduce ARMv7 architecture")
> > Fixes: 4a7e4626975a ("mk: introduce NXP dpaa2 architecture based on armv8-a")
> >
> > Reported-by: Jan Viktorin <viktorin@rehivetech.com>
> > Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
>
> Tested-by: Jan Viktorin <viktorin@rehivetech.com>
Applied, thanks
@@ -57,7 +57,7 @@
MACHINE_CFLAGS += -march=armv7-a
ifdef CONFIG_RTE_ARCH_ARM_TUNE
-MACHINE_CFLAGS += -mtune=$(CONFIG_RTE_ARCH_ARM_TUNE)
+MACHINE_CFLAGS += -mtune=$(CONFIG_RTE_ARCH_ARM_TUNE:"%"=%)
endif
MACHINE_CFLAGS += -mfpu=neon
@@ -56,5 +56,5 @@
MACHINE_CFLAGS += -march=armv8-a
ifdef CONFIG_RTE_ARCH_ARM_TUNE
-MACHINE_CFLAGS += -mcpu=$(CONFIG_RTE_ARCH_ARM_TUNE)
+MACHINE_CFLAGS += -mcpu=$(CONFIG_RTE_ARCH_ARM_TUNE:"%"=%)
endif