diff mbox

[dpdk-dev,v13,7/7] doc: remove deprecation notice for rte_bus

Message ID 763aa92c3be591b20b07d3ba6855ef594d4cbdab.1491906224.git.gaetan.rivet@6wind.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gaëtan Rivet April 11, 2017, 11:07 a.m. UTC 
  From: Shreyansh Jain <shreyansh.jain@nxp.com>

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 doc/guides/rel_notes/release_17_02.rst | 2 +-
 lib/librte_eal/bsdapp/eal/Makefile     | 2 +-
 lib/librte_eal/linuxapp/eal/Makefile   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Shreyansh Jain April 11, 2017, 11:32 a.m. UTC | #1 
Hello Gaetan,

On Tuesday 11 April 2017 04:37 PM, Gaetan Rivet wrote:
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>  doc/guides/rel_notes/release_17_02.rst | 2 +-
>  lib/librte_eal/bsdapp/eal/Makefile     | 2 +-
>  lib/librte_eal/linuxapp/eal/Makefile   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

[...]

I think you removed the deprecation.rst file from original patch. In 
which case, the headline of the patch is now not correct.

-
Shreyansh
Gaëtan Rivet April 11, 2017, 11:54 a.m. UTC | #2 
Hi Shreyansh,

On Tue, Apr 11, 2017 at 05:02:31PM +0530, Shreyansh Jain wrote:
>Hello Gaetan,
>
>On Tuesday 11 April 2017 04:37 PM, Gaetan Rivet wrote:
>>From: Shreyansh Jain <shreyansh.jain@nxp.com>
>>
>>Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>---
>> doc/guides/rel_notes/release_17_02.rst | 2 +-
>> lib/librte_eal/bsdapp/eal/Makefile     | 2 +-
>> lib/librte_eal/linuxapp/eal/Makefile   | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>[...]
>
>I think you removed the deprecation.rst file from original patch. In 
>which case, the headline of the patch is now not correct.
>

Yes you're right, actually the deprecation notice had already been removed.
I wanted to keep the patches the way they were as much as possible
however in order for readers to be able to find the reference in the
original series.

Now that you highlighted this patch, I see that I made an error
by keeping the release note update in the 17.02 file instead of 17.05.
diff mbox

Patch

diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst
index 357965a..e9d2e00 100644
--- a/doc/guides/rel_notes/release_17_02.rst
+++ b/doc/guides/rel_notes/release_17_02.rst
@@ -357,7 +357,7 @@  The libraries prepended with a plus sign were incremented in this version.
      librte_cmdline.so.2
      librte_cryptodev.so.2
      librte_distributor.so.1
-     librte_eal.so.3
+   + librte_eal.so.4
    + librte_ethdev.so.6
      librte_hash.so.2
      librte_ip_frag.so.1
diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index 16791df..a0f9950 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -48,7 +48,7 @@  LDLIBS += -lgcc_s
 
 EXPORT_MAP := rte_eal_version.map
 
-LIBABIVER := 3
+LIBABIVER := 4
 
 # specific to bsdapp exec-env
 SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) := eal.c
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index 8624ad2..640afd0 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -37,7 +37,7 @@  ARCH_DIR ?= $(RTE_ARCH)
 EXPORT_MAP := rte_eal_version.map
 VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)
 
-LIBABIVER := 3
+LIBABIVER := 4
 
 VPATH += $(RTE_SDK)/lib/librte_eal/common