diff mbox

[dpdk-dev] ethtool: disable promiscuous mode by default

Message ID 1492027099-9193-1-git-send-email-qi.z.zhang@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Qi Zhang April 12, 2017, 7:58 p.m. UTC 
  Disable promiscuous mode by default since VLAN filter
does not work when promiscuous mode is enabled.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 examples/ethtool/ethtool-app/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Remy Horton April 18, 2017, 2:26 p.m. UTC | #1 
Probably ought to also add a new command so that promiscuous mode can be 
enabled if needed.

On 12/04/2017 20:58, Qi Zhang wrote:
> Disable promiscuous mode by default since VLAN filter
> does not work when promiscuous mode is enabled.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  examples/ethtool/ethtool-app/main.c | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Remy Horton <remy.horton@intel.com>
Thomas Monjalon April 21, 2017, 12:23 a.m. UTC | #2 
18/04/2017 16:26, Remy Horton:
> Probably ought to also add a new command so that promiscuous mode can be
> enabled if needed.
> 
> On 12/04/2017 20:58, Qi Zhang wrote:
> > Disable promiscuous mode by default since VLAN filter
> > does not work when promiscuous mode is enabled.
> > 
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > 
> >  examples/ethtool/ethtool-app/main.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Acked-by: Remy Horton <remy.horton@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
index 2c655d8..6d50d46 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -172,7 +172,6 @@  static void setup_ports(struct app_config *app_cfg, int cnt_ports)
 				 "%s:%i: rte_eth_dev_start failed",
 				 __FILE__, __LINE__
 				);
-		rte_eth_promiscuous_enable(idx_port);
 		rte_eth_macaddr_get(idx_port, &ptr_port->mac_addr);
 		rte_spinlock_init(&ptr_port->lock);
 	}