diff mbox

[dpdk-dev] mk: link ring mempool by default for app build

Message ID 1492074127-24339-1-git-send-email-shreyansh.jain@nxp.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shreyansh Jain April 13, 2017, 9:02 a.m. UTC 
  Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Context:
 From the discussion in [1], it was observed that application should
 have a default pool already linked even in case of shared builds.
 Ring is especially important because packet mbuf creation API refer to
 ring_mp_mc as default handler.
 
 Documentation for this is pending.

 [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html

 mk/rte.app.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Olivier Matz April 18, 2017, 12:04 p.m. UTC | #1 
On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> ---
> Context:
>  From the discussion in [1], it was observed that application should
>  have a default pool already linked even in case of shared builds.
>  Ring is especially important because packet mbuf creation API refer to
>  ring_mp_mc as default handler.
>  
>  Documentation for this is pending.
> 
>  [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html

Maybe this comment could go in the patch.

Thanks,
Olivier
Shreyansh Jain April 18, 2017, 12:25 p.m. UTC | #2 
Hi Olivier,

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Tuesday, April 18, 2017 5:34 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; bruce.richardson@intel.com;
> john.miller@atomicrules.com
> Subject: Re: [PATCH] mk: link ring mempool by default for app build
> 
> On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain <shreyansh.jain@nxp.com>
> wrote:
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> > ---
> > Context:
> >  From the discussion in [1], it was observed that application should
> >  have a default pool already linked even in case of shared builds.
> >  Ring is especially important because packet mbuf creation API refer to
> >  ring_mp_mc as default handler.
> >
> >  Documentation for this is pending.
> >
> >  [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html
> 
> Maybe this comment could go in the patch.
 
I can send another version of the patch with some part of the above documentation within the patch commit.

> 
> Thanks,
> Olivier
Thomas Monjalon April 19, 2017, 12:26 p.m. UTC | #3 
18/04/2017 14:25, Shreyansh Jain:
> Hi Olivier,
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> > On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain
> > <shreyansh.jain@nxp.com> wrote:
> > > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > 
> > Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")
> > 
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > 
> > > ---
> > > 
> > > Context:
> > >  From the discussion in [1], it was observed that application should
> > >  have a default pool already linked even in case of shared builds.
> > >  Ring is especially important because packet mbuf creation API refer to
> > >  ring_mp_mc as default handler.
> > >  
> > >  Documentation for this is pending.
> > >  
> > >  [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html
> > 
> > Maybe this comment could go in the patch.
> 
> I can send another version of the patch with some part of the above
> documentation within the patch commit.

Moved the mempool ring line below the mempool line,
Added the explanations, and
Applied, thanks
diff mbox

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 4c659e9..2462808 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -97,6 +97,7 @@  _LDLIBS-$(CONFIG_RTE_LIBRTE_RING)           += -lrte_ring
 _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)            += -lrte_eal
 _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)        += -lrte_cmdline
 _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER)        += -lrte_reorder
+_LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
 
 ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI)            += -lrte_kni
@@ -104,7 +105,6 @@  endif
 
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
 # plugins (link only if static libraries)
-_LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
 _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_STACK)  += -lrte_mempool_stack
 
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet