diff mbox

[dpdk-dev] net/i40e: downgrade unnecessary error print

Message ID 1492132594-128369-1-git-send-email-wenzhuo.lu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wenzhuo Lu April 14, 2017, 1:16 a.m. UTC 
  When receiving the unsupported AQ messages, it's taken as
an error. It's not appropriate and triggers too much
unnecessary print.

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit April 14, 2017, 10:49 a.m. UTC | #1 
On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:
> When receiving the unsupported AQ messages, it's taken as
> an error. It's not appropriate and triggers too much
> unnecessary print.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net/master, thanks.
Ferruh Yigit April 14, 2017, 3:53 p.m. UTC | #2 
On 4/14/2017 11:49 AM, Ferruh Yigit wrote:
> On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:
>> When receiving the unsupported AQ messages, it's taken as
>> an error. It's not appropriate and triggers too much
>> unnecessary print.
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

Hi Wenzhuo, Jingjing,

Another i40e log print, in WARNING level:

i40e_update_default_filter_setting(): Cannot remove the default macvlan
filter

I am getting this one always.

If this is produced always, what do you think downgrade this one too? Or
remove completely perhaps?

Thanks,
ferruh
Wenzhuo Lu April 17, 2017, 2:58 a.m. UTC | #3 
Hi Ferruh,

> -----Original Message-----

> From: Yigit, Ferruh

> Sent: Friday, April 14, 2017 11:54 PM

> To: Lu, Wenzhuo; Wu, Jingjing

> Cc: dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error print

> 

> On 4/14/2017 11:49 AM, Ferruh Yigit wrote:

> > On 4/14/2017 2:16 AM, Wenzhuo Lu wrote:

> >> When receiving the unsupported AQ messages, it's taken as an error.

> >> It's not appropriate and triggers too much unnecessary print.

> >>

> >> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

> >

> > Applied to dpdk-next-net/master, thanks.

> 

> Hi Wenzhuo, Jingjing,

> 

> Another i40e log print, in WARNING level:

> 

> i40e_update_default_filter_setting(): Cannot remove the default macvlan

> filter

> 

> I am getting this one always.

> 

> If this is produced always, what do you think downgrade this one too? Or

> remove completely perhaps?

Checked the comment in the code, it's expected that it will fail in some scenarios. So I'll send a patch to downgrade it to "debug".

> 

> Thanks,

> ferruh
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9eb1a65..1773e05 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -5774,7 +5774,7 @@  struct i40e_vsi *
 					RTE_ETH_EVENT_INTR_LSC, NULL);
 			break;
 		default:
-			PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+			PMD_DRV_LOG(DEBUG, "Request %u is not supported yet",
 				    opcode);
 			break;
 		}