diff mbox

[dpdk-dev] net/mlx5: fix empty RSS flow action

Message ID 7f247b841bc83d6c9446942a0a5b11fd709e7f08.1492504184.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nélio Laranjeiro April 18, 2017, 8:30 a.m. UTC 
  Empty RSS action is causing a segmentation fault.

Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5_flow.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Ferruh Yigit April 18, 2017, 9:55 a.m. UTC | #1 
On 4/18/2017 9:30 AM, Nelio Laranjeiro wrote:
> Empty RSS action is causing a segmentation fault.
> 
> Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8d62f85..1784e64 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -506,6 +506,13 @@  priv_flow_validate(struct priv *priv,
 				actions->conf;
 			uint16_t n;
 
+			if (!rss || !rss->num) {
+				rte_flow_error_set(error, EINVAL,
+						   RTE_FLOW_ERROR_TYPE_ACTION,
+						   actions,
+						   "no valid queues");
+				return -rte_errno;
+			}
 			if (action->queues_n == 1) {
 				uint16_t found = 0;