diff mbox

[dpdk-dev,v3] app/test-crypto-perf: fix crypto operation resubmission

Message ID 1492526911-110534-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Fan Zhang April 18, 2017, 2:48 p.m. UTC 
  This patch fixes the crypto operation resubmission problem in crypto
perferformance test. Originally, when needed crypto ops amount is
smaller than the enqueued crypto ops in the last round, one or more
processed crypto operations will be re-enqueued.

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---

v3:
- Added changes
- Added Pablo's ack

v2:
- Fixed memmove src and size calculation

 app/test-crypto-perf/cperf_test_throughput.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

De Lara Guarch, Pablo April 18, 2017, 3:24 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Tuesday, April 18, 2017 3:49 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.com
> Subject: [PATCH v3] app/test-crypto-perf: fix crypto operation resubmission
> 
> This patch fixes the crypto operation resubmission problem in crypto
> perferformance test. Originally, when needed crypto ops amount is
> smaller than the enqueued crypto ops in the last round, one or more
> processed crypto operations will be re-enqueued.
> 
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
De Lara Guarch, Pablo April 18, 2017, 3:26 p.m. UTC | #2 
CC'ing stable@dpdk.org.

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Tuesday, April 18, 2017 4:24 PM
> To: Zhang, Roy Fan; dev@dpdk.org
> Cc: stable@dpdk.com
> Subject: Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: fix crypto
> operation resubmission
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Tuesday, April 18, 2017 3:49 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo; stable@dpdk.com
> > Subject: [PATCH v3] app/test-crypto-perf: fix crypto operation
> resubmission
> >
> > This patch fixes the crypto operation resubmission problem in crypto
> > perferformance test. Originally, when needed crypto ops amount is
> > smaller than the enqueued crypto ops in the last round, one or more
> > processed crypto operations will be re-enqueued.
> >
> > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> > application")
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Applied to dpdk-next-crypto.
> Thanks,
> 
> Pablo
diff mbox

Patch

diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c
index 70ec4ff..61b27ea 100644
--- a/app/test-crypto-perf/cperf_test_throughput.c
+++ b/app/test-crypto-perf/cperf_test_throughput.c
@@ -348,6 +348,19 @@  cperf_throughput_test_runner(void *test_ctx)
 					ops_needed, ctx->sess, ctx->options,
 					ctx->test_vector);
 
+			/**
+			 * When ops_needed is smaller than ops_enqd, the
+			 * unused ops need to be moved to the front for
+			 * next round use.
+			 */
+			if (unlikely(ops_enqd > ops_needed)) {
+				size_t nb_b_to_mov = ops_unused * sizeof(
+						struct rte_crypto_op *);
+
+				memmove(&ops[ops_needed], &ops[ops_enqd],
+					nb_b_to_mov);
+			}
+
 #ifdef CPERF_LINEARIZATION_ENABLE
 			if (linearize) {
 				/* PMD doesn't support scatter-gather and source buffer