diff mbox

[dpdk-dev] crypto/scheduler: fix slave init attach

Message ID 1492609337-44733-1-git-send-email-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Fan Zhang April 19, 2017, 1:42 p.m. UTC 
  Fixes: 881851676940 ("crypto/scheduler: improve commandline parsing")

This patch fix the slaves attaching initially.

Originally, the scheduler will try to attach the slaves passed by the
cmdline option in the initial stage, this may break the sequence
of the slaves inside the scheduler.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/scheduler/scheduler_pmd.c | 21 ---------------------
 1 file changed, 21 deletions(-)

Comments

De Lara Guarch, Pablo April 19, 2017, 4:04 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Wednesday, April 19, 2017 2:42 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.com
> Subject: [PATCH] crypto/scheduler: fix slave init attach
> 
> Fixes: 881851676940 ("crypto/scheduler: improve commandline parsing")
> 
> This patch fix the slaves attaching initially.
> 
> Originally, the scheduler will try to attach the slaves passed by the
> cmdline option in the initial stage, this may break the sequence
> of the slaves inside the scheduler.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Squashed into the affected commit in the subtree.

Thanks,
Pablo
diff mbox

Patch

diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c
index f2a1d2a..2a92d1e 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -160,27 +160,6 @@  cryptodev_scheduler_create(const char *name,
 	}
 
 	for (i = 0; i < init_params->nb_slaves; i++) {
-		struct rte_cryptodev *slave_dev =
-				rte_cryptodev_pmd_get_named_dev(
-					init_params->slave_names[i]);
-
-		/* if the slave dev exists in the system, attach it */
-		if (slave_dev) {
-			int ret = rte_cryptodev_scheduler_slave_attach(
-				dev->data->dev_id,
-				slave_dev->data->dev_id);
-
-			if (ret < 0)
-				return ret;
-
-			CS_LOG_INFO("Scheduler %s attached slave %s\n",
-					dev->data->name,
-					init_params->slave_names[i]);
-
-			continue;
-		}
-
-		/* if the slave doesn't exist, store and attach later*/
 		sched_ctx->init_slave_names[sched_ctx->nb_init_slaves] =
 			rte_zmalloc_socket(
 				NULL,