diff mbox

[dpdk-dev] examples/l2fwd-crypto: fix padding calculation

Message ID 1492612674-147730-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo April 19, 2017, 2:37 p.m. UTC 
  For padding calculation, it is necessary to know if algorithm
is a block cipher or stream cipher algorithm, and know the
block size for the algorithm.

In the application, this block size should be only the
cipher block size, but if authentication was used too,
it was being overwritten by the authentication block size,
which is not needed.

Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 examples/l2fwd-crypto/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Fan Zhang April 19, 2017, 2:47 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, April 19, 2017 3:38 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix padding calculation
> 
> For padding calculation, it is necessary to know if algorithm is a block cipher or
> stream cipher algorithm, and know the block size for the algorithm.
> 
> In the application, this block size should be only the cipher block size, but if
> authentication was used too, it was being overwritten by the authentication
> block size, which is not needed.
> 
> Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
De Lara Guarch, Pablo April 19, 2017, 4:08 p.m. UTC | #2 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Wednesday, April 19, 2017 3:47 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix padding
> calculation
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Wednesday, April 19, 2017 3:38 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix padding
> calculation
> >
> > For padding calculation, it is necessary to know if algorithm is a block
> cipher or
> > stream cipher algorithm, and know the block size for the algorithm.
> >
> > In the application, this block size should be only the cipher block size, but
> if
> > authentication was used too, it was being overwritten by the
> authentication
> > block size, which is not needed.
> >
> > Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Applied to dpdk-next-crypto.

Pablo
diff mbox

Patch

diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 720a1c2..d7db55d 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1705,7 +1705,6 @@  initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
 				continue;
 			}
 
-			options->block_size = cap->sym.auth.block_size;
 			/*
 			 * Check if length of provided AAD is supported
 			 * by the algorithm chosen.