[dpdk-dev] net/sfc: fix LSC interrupt support for UIO cases

Message ID 1492777002-25223-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andrew Rybchenko April 21, 2017, 12:16 p.m. UTC
  Recently link status change interrupt was enabled by default in testpmd,
it has opened the driver bug with not working LSC interrupt if either
igb_uio or uio_pci_generic kernel driver is used.

Fixes: 06bc197796e2 ("net/sfc: interrupts support sufficient for event queue init")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_intr.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Ferruh Yigit April 21, 2017, 1:05 p.m. UTC | #1
On 4/21/2017 1:16 PM, Andrew Rybchenko wrote:
> Recently link status change interrupt was enabled by default in testpmd,
> it has opened the driver bug with not working LSC interrupt if either
> igb_uio or uio_pci_generic kernel driver is used.
> 
> Fixes: 06bc197796e2 ("net/sfc: interrupts support sufficient for event queue init")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/sfc/sfc_intr.c b/drivers/net/sfc/sfc_intr.c
index 7d91a2a..7eb4b86 100644
--- a/drivers/net/sfc/sfc_intr.c
+++ b/drivers/net/sfc/sfc_intr.c
@@ -312,9 +312,11 @@  sfc_intr_attach(struct sfc_adapter *sa)
 
 	switch (pci_dev->intr_handle.type) {
 #ifdef RTE_EXEC_ENV_LINUXAPP
+	case RTE_INTR_HANDLE_UIO_INTX:
 	case RTE_INTR_HANDLE_VFIO_LEGACY:
 		intr->type = EFX_INTR_LINE;
 		break;
+	case RTE_INTR_HANDLE_UIO:
 	case RTE_INTR_HANDLE_VFIO_MSI:
 	case RTE_INTR_HANDLE_VFIO_MSIX:
 		intr->type = EFX_INTR_MESSAGE;