diff mbox

[dpdk-dev,v2] eal: optimize timer routines

Message ID 20170502051951.25038-1-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob May 2, 2017, 5:19 a.m. UTC 
  Since DPDK has only two timer sources,
Avoid &eal_timer_source memory read and followed
by the switch case statement when
RTE_LIBEAL_USE_HPET is not defined.

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v2:
- Rearrage the ifdef to avoiding the #else part by
"unifdef" the first occurence of rte_get_tsc_cycles(Thomas)
---
 lib/librte_eal/common/include/generic/rte_cycles.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Thomas Monjalon May 5, 2017, 1:28 p.m. UTC | #1 
02/05/2017 07:19, Jerin Jacob:
> Since DPDK has only two timer sources,
> Avoid &eal_timer_source memory read and followed
> by the switch case statement when
> RTE_LIBEAL_USE_HPET is not defined.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

It is not a fix but it is simple and safe enough to be in 17.05-rc4.

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/include/generic/rte_cycles.h b/lib/librte_eal/common/include/generic/rte_cycles.h
index 00103ca9f..0e645c2c4 100644
--- a/lib/librte_eal/common/include/generic/rte_cycles.h
+++ b/lib/librte_eal/common/include/generic/rte_cycles.h
@@ -150,15 +150,17 @@  int rte_eal_hpet_init(int make_default);
 static inline uint64_t
 rte_get_timer_cycles(void)
 {
+#ifdef RTE_LIBEAL_USE_HPET
 	switch(eal_timer_source) {
 	case EAL_TIMER_TSC:
+#endif
 		return rte_get_tsc_cycles();
-	case EAL_TIMER_HPET:
 #ifdef RTE_LIBEAL_USE_HPET
+	case EAL_TIMER_HPET:
 		return rte_get_hpet_cycles();
-#endif
 	default: rte_panic("Invalid timer source specified\n");
 	}
+#endif
 }
 
 /**
@@ -170,15 +172,17 @@  rte_get_timer_cycles(void)
 static inline uint64_t
 rte_get_timer_hz(void)
 {
+#ifdef RTE_LIBEAL_USE_HPET
 	switch(eal_timer_source) {
 	case EAL_TIMER_TSC:
+#endif
 		return rte_get_tsc_hz();
-	case EAL_TIMER_HPET:
 #ifdef RTE_LIBEAL_USE_HPET
+	case EAL_TIMER_HPET:
 		return rte_get_hpet_hz();
-#endif
 	default: rte_panic("Invalid timer source specified\n");
 	}
+#endif
 }
 /**
  * Wait at least us microseconds.