[dpdk-dev] app/testpmd: disable latency stats by default
Checks
Commit Message
Disable latency stats gathering by default,
so there is not performance degradation if user
is not interested in them.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test-pmd/testpmd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Comments
CC'ing Jingjing.
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, May 02, 2017 2:11 PM
> To: jingjing@intel.com; Pattan, Reshma
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: disable latency stats by default
>
> Disable latency stats gathering by default,
> so there is not performance degradation if user
> is not interested in them.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> app/test-pmd/testpmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index dfe6442..23dfdb0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc,
> packet_fwd_t pkt_fwd)
> }
> #endif
> #ifdef RTE_LIBRTE_LATENCY_STATS
> - if (latencystats_lcore_id == rte_lcore_id())
> + if (latencystats_enabled != 0 &&
> + latencystats_lcore_id == rte_lcore_id())
> rte_latencystats_update();
> #endif
>
> @@ -2238,8 +2239,9 @@ main(int argc, char** argv)
> rte_panic("Empty set of forwarding logical cores - check the
> "
> "core mask supplied in the command
> parameters\n");
>
> - /* Bitrate stats disabled by default */
> + /* Bitrate/latency stats disabled by default */
> bitrate_enabled = 0;
> + latencystats_enabled = 0;
>
> argc -= diag;
> argv += diag;
> --
> 2.7.4
@@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)
}
#endif
#ifdef RTE_LIBRTE_LATENCY_STATS
- if (latencystats_lcore_id == rte_lcore_id())
+ if (latencystats_enabled != 0 &&
+ latencystats_lcore_id == rte_lcore_id())
rte_latencystats_update();
#endif
@@ -2238,8 +2239,9 @@ main(int argc, char** argv)
rte_panic("Empty set of forwarding logical cores - check the "
"core mask supplied in the command parameters\n");
- /* Bitrate stats disabled by default */
+ /* Bitrate/latency stats disabled by default */
bitrate_enabled = 0;
+ latencystats_enabled = 0;
argc -= diag;
argv += diag;