diff mbox

[dpdk-dev] net/ixgbe: fix VF Rx mode if allmulticast is disabled

Message ID 1493891680-39384-1-git-send-email-wei.dai@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wei Dai May 4, 2017, 9:54 a.m. UTC 
  Some customers find that 82599 NIC DPDK VF PMD can't receive any
broadcast packets when it is bound to igb_uio in the first time
to run a DPDK application like testpmd. But when the application
is quited and run again, the DPDK VF PMD can receive broadcast
packets again. The associated PF is run by kernel driver when
the VF is driven by DPDK PMD.

When patch fixes this issue.

Fixes: 260e2e22e26f ("net/ixgbe/base: move multicast mode update")
Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mode on VF")
Cc: stable@dpdk.org

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wenzhuo Lu May 5, 2017, 1:52 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Dai, Wei
> Sent: Thursday, May 4, 2017 5:55 PM
> To: Zhang, Helin; Ananyev, Konstantin; Lu, Wenzhuo
> Cc: dev@dpdk.org; Dai, Wei; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix VF Rx mode if allmulticast is disabled
> 
> Some customers find that 82599 NIC DPDK VF PMD can't receive any
> broadcast packets when it is bound to igb_uio in the first time to run a DPDK
> application like testpmd. But when the application is quited and run again,
> the DPDK VF PMD can receive broadcast packets again. The associated PF is
> run by kernel driver when the VF is driven by DPDK PMD.
> 
> When patch fixes this issue.
> 
> Fixes: 260e2e22e26f ("net/ixgbe/base: move multicast mode update")
> Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mode on VF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Thomas Monjalon May 5, 2017, 3:03 p.m. UTC | #2 
> > Some customers find that 82599 NIC DPDK VF PMD can't receive any
> > broadcast packets when it is bound to igb_uio in the first time to run a DPDK
> > application like testpmd. But when the application is quited and run again,
> > the DPDK VF PMD can receive broadcast packets again. The associated PF is
> > run by kernel driver when the VF is driven by DPDK PMD.
> > 
> > When patch fixes this issue.
> > 
> > Fixes: 260e2e22e26f ("net/ixgbe/base: move multicast mode update")
> > Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mode on VF")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index bbae4f9..dbe777d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -7852,7 +7852,7 @@  ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev)
 {
 	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE);
+	hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_MULTI);
 }
 
 static void ixgbevf_mbx_process(struct rte_eth_dev *dev)