diff mbox

[dpdk-dev] net/null: do not touch mbuf next or nb segs on Rx

Message ID 20170504154358.40122-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit May 4, 2017, 3:43 p.m. UTC 
  mbuf next and nb_segs fields already have the default values when get
from mempool, no need to update them in PMD.

See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/net/null/rte_eth_null.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Olivier Matz May 9, 2017, 7:24 a.m. UTC | #1 
On Thu,  4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> mbuf next and nb_segs fields already have the default values when get
> from mempool, no need to update them in PMD.
> 
> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/null/rte_eth_null.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index abf3ec7..2c94339 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
>  					packet_size);
>  		bufs[i]->data_len = (uint16_t)packet_size;
>  		bufs[i]->pkt_len = packet_size;
> -		bufs[i]->nb_segs = 1;
> -		bufs[i]->next = NULL;
>  		bufs[i]->port = h->internals->port_id;
>  	}
>  

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Ferruh Yigit May 12, 2017, 11:59 a.m. UTC | #2 
On 5/9/2017 8:24 AM, Olivier Matz wrote:
> On Thu,  4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> mbuf next and nb_segs fields already have the default values when get
>> from mempool, no need to update them in PMD.
>>
>> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index abf3ec7..2c94339 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -139,8 +139,6 @@  eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 					packet_size);
 		bufs[i]->data_len = (uint16_t)packet_size;
 		bufs[i]->pkt_len = packet_size;
-		bufs[i]->nb_segs = 1;
-		bufs[i]->next = NULL;
 		bufs[i]->port = h->internals->port_id;
 	}