diff mbox

[dpdk-dev] net/ixgbe: do not touch mbuf initialized fields

Message ID 20170504155923.41103-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit May 4, 2017, 3:59 p.m. UTC 
  See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Wenzhuo Lu May 5, 2017, 12:57 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, May 4, 2017 11:59 PM
> To: Lu, Wenzhuo; Ananyev, Konstantin
> Cc: dev@dpdk.org; Olivier Matz
> Subject: [PATCH] net/ixgbe: do not touch mbuf initialized fields
> 
> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Ferruh Yigit May 12, 2017, 11:33 a.m. UTC | #2 
On 5/5/2017 1:57 AM, Lu, Wenzhuo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, May 4, 2017 11:59 PM
>> To: Lu, Wenzhuo; Ananyev, Konstantin
>> Cc: dev@dpdk.org; Olivier Matz
>> Subject: [PATCH] net/ixgbe: do not touch mbuf initialized fields
>>
>> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 1e07895..590ab63 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -4111,10 +4111,7 @@  ixgbe_alloc_rx_queue_mbufs(struct ixgbe_rx_queue *rxq)
 			return -ENOMEM;
 		}
 
-		rte_mbuf_refcnt_set(mbuf, 1);
-		mbuf->next = NULL;
 		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
-		mbuf->nb_segs = 1;
 		mbuf->port = rxq->port_id;
 
 		dma_addr =