diff mbox

[dpdk-dev] eal/linux: fix phys addresses not avaialbe for Xen dom0

Message ID 1494000613-3709-1-git-send-email-jianfeng.tan@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Jianfeng Tan May 5, 2017, 4:10 p.m. UTC 
  When physical NICs are binded to igb_uio/uio-pci-generic, they cannot
be used in DPDK app in Xen dom0.

Due to (1) a restriction that phys addresses should be availabe is added
by commit cdc242f260e7 ("eal/linux: support running as unprivileged user"),
(2) and previous implementation of the test to check if phys addresses are
available (using a variable on the stack) just works for non-Xen
environment. Actually, for Xen dom0, the physical addresses are always
available if the memory is initialized successfully..

To fix it, we add an precheck to bypass the physical address availability
test.

Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")

Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 lib/librte_eal/linuxapp/eal/eal_memory.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon May 10, 2017, 12:58 p.m. UTC | #1 
05/05/2017 18:10, Jianfeng Tan:
> When physical NICs are binded to igb_uio/uio-pci-generic, they cannot
> be used in DPDK app in Xen dom0.
> 
> Due to (1) a restriction that phys addresses should be availabe is added
> by commit cdc242f260e7 ("eal/linux: support running as unprivileged user"),
> (2) and previous implementation of the test to check if phys addresses are
> available (using a variable on the stack) just works for non-Xen
> environment. Actually, for Xen dom0, the physical addresses are always
> available if the memory is initialized successfully..
> 
> To fix it, we add an precheck to bypass the physical address availability
> test.
> 
> Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied, thanks

Is Xen dom0 working?
Why is there no answer to my questions (in another thread)?
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 618a09b..ebe0683 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -133,6 +133,10 @@  test_phys_addrs_available(void)
 	uint64_t tmp;
 	phys_addr_t physaddr;
 
+	/* For dom0, phys addresses can always be available */
+	if (rte_xen_dom0_supported())
+		return;
+
 	physaddr = rte_mem_virt2phy(&tmp);
 	if (physaddr == RTE_BAD_PHYS_ADDR) {
 		RTE_LOG(ERR, EAL,