Message ID | 1495532028-9700-2-git-send-email-hemant.agrawal@nxp.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 55036374F; Tue, 23 May 2017 11:34:18 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57]) by dpdk.org (Postfix) with ESMTP id 955F1378B; Tue, 23 May 2017 11:34:13 +0200 (CEST) Received: from DM5PR03CA0048.namprd03.prod.outlook.com (10.174.189.165) by CY4PR03MB2792.namprd03.prod.outlook.com (10.173.38.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Tue, 23 May 2017 09:34:12 +0000 Received: from BN1BFFO11FD040.protection.gbl (2a01:111:f400:7c10::1:186) by DM5PR03CA0048.outlook.office365.com (2603:10b6:4:3b::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Tue, 23 May 2017 09:34:12 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD040.mail.protection.outlook.com (10.58.144.103) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1075.5 via Frontend Transport; Tue, 23 May 2017 09:34:11 +0000 Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.134.28]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v4N9Y5su022923; Tue, 23 May 2017 02:34:09 -0700 From: Hemant Agrawal <hemant.agrawal@nxp.com> To: <olivier.matz@6wind.com> CC: <dev@dpdk.org>, <stable@dpdk.org>, <shreyansh.jain@nxp.com> Date: Tue, 23 May 2017 15:03:48 +0530 Message-ID: <1495532028-9700-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1495532028-9700-1-git-send-email-hemant.agrawal@nxp.com> References: <1495532028-9700-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131400056519580456; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39400400002)(39410400002)(39380400002)(39450400003)(39860400002)(39840400002)(39850400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(47776003)(305945005)(36756003)(86362001)(104016004)(50466002)(53936002)(5660300001)(76176999)(33646002)(8656002)(54906002)(50986999)(105606002)(5003940100001)(189998001)(50226002)(106466001)(8936002)(77096006)(498600001)(2351001)(38730400002)(81166006)(110136004)(6666003)(356003)(2906002)(8676002)(4326008)(85426001)(6916009)(2950100002)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2792; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD040; 1:vI2E8p5U1I3++PPEAFr0GE36j+ROOxVvnfJjMZKaJIGPZJ89auZvz4tcf+tKqrJ5fDHGyp4seqP9PAl+3O18GWEQN0jI7la1zC21K9Jtb9a3HSwqgKmMlQdVQnpBbrGXR4SFrGvy9YZCqNCNkibkZ3l3+3lxd0CSfVWgD+zAXGUSlIDFi4HSfz4g2AriLNN3IyXq9fcSxmHMS0nGCJKc+NgK6v7aYTyuaQQr5RhQLmd1dgAqwCFNxyFZ5P4NMtL1xoMNIplJ4qu3qGQqVHMRSn5xjrpsIFz5IzRBxXnAaD8TYtCpb+hwbDdJX0d8pWUKQziWV/Hpo6KbzN5x+MOsCqKApcKbyx0Ui3zqOYMQ2jAI3LNf91MZNWq6IS+60+7zyB0HNgXBREbGnZgxIFwOrBafA1pXDB3k2Be6TwVXWufk97/YlqcBz5GG+oZZVyxOajfQsVaFh1BoB/fxGERfn6tiAtQ6JIc1o/TXVbHoriCf+Nb6jUTPMNef/ejZU7cg2m3euP12f9XoU/WlMOYl8hrRfZ9N8UwCo3o8/aY1ldLFwh5T6Bq4IbUHDuX2i3pq/KRYPhdxVxOe+xVPZpf0Kqk6+/3m+kO8nUqLRezqKA+uDh7m9caodpfXjRzSphhbL/tboouyTzXwXjuzizz8rEp2LzJNAm/0nmKBq9APgG0gWgSK1Q6rFKGR292XMc17TXFNOdHbVc3BzhrHS+izwj2KqGuEOtbnCFEddqb1yNo= MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR03MB2792: X-MS-Office365-Filtering-Correlation-Id: c023b4b4-ac0e-47d2-d050-08d4a1bedeb4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:CY4PR03MB2792; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 3:Ykzxl5JpSL8G1/FmJZTz/c2sfd6VF+iPxBPiHDeeqyl5gppN6NQxgfWkbwtB1rwyD6T0W1vLlNwXiri0xy4uETIRWoiJdX1UbXhIFciQ0kohP05GTUgvPC4udE6bjQHKRU7IUiZWYviV91X1WdFGa3C1m4FCqzFgaVBWAGNT11SUM7O17VPOm1IDIthP/wW6AHhB8OY6lXrMhG3dyMugKvhVdbHdfuE2fq7Ki039p+g9EnFnwPZWYMWFBzaS2J9C87IstaKcEH7TT96jjzz0LqefjU+nrBeDlrlo+dz8RN2kSAKf+FC/vWSNwAPLrGyjvB4DIOoTX5kf6DLq1if8s1yS7Urks5IibfHPA7dgr0/93uiULpqpbXv7kmy9d2lXXNUiVT58bRiH/Yf1QyyF9BVXwJ4yh+hLT7zHdEGBCfUsPETkxG+4JazuqgOmZT8I; 25:KosBXV1B5wedw3Z5hfDOUIcWWmrVXMmqvdzkL5ogNpUiboyTduqLA9c8FQAArCFw0+87xeg+2/WTRWJ7YxoOad7gsaX6JEkksWw/Ft1OfapG4BoyRPXlGr2KugRwvts0iv8vICPuYB0suOj4KH/SO9jbe1tFZ1OpYqao7NqatsyBZsqWLgo+FacjiFm79R6XdY2+X6JNzn5Lo+ni4V1h7iGzVEJilJAv9Q8wV6EhhgwJ/q2hoBrKwKUaGHYt/rOoCBzI1mRKWDLBl1Eh70IOpjboulLFtdqxOWPZnHkck9fklrXkMefvsQ0fvUfRyM/EAwkW49dUqVlA699HJCK04OrYeZ3hecDkIJd8nwoCC8EC/c51tf28BMyiLn8VoLtTkYB5NWxEtORW9LyRsqN7vdqM4XDG0PWiToepZ/z5XI5qDjC9cueZaiWkoW9vvQxzBciiuIaGz6EZObL6VmPSdInqnmwOQnABKXHauf6OC8E= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 31:qWqtzk3lYYpz1E6lBZwm55rtwnghIfcJ7euB4lBAabTd3dBJdGgqEgrG7YPD2J1LtpkoWKUDgZp4OjR4cg7MIlssOD26w99ruzwao0dzrbSX8u0SrksiRG4t6sQ6K/MmQlgqO1sirJ49xpOs+3bDdr+2FMcuhyzD1/NnPP7hwLdBdNq9PA8CoajBu5jB3yj5EbZMmBzhVDwgeEcuzDkdJCydFicp/K0ItWLSvPal1ZFiUUxmDRxkmCgaIreZ2Ba8+Umgo3X08z84UeEFOVPIqQ== X-Microsoft-Antispam-PRVS: <CY4PR03MB279260C39C9B31FAA9131DED89F90@CY4PR03MB2792.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13015025)(13018025)(8121501046)(13023025)(13024025)(13017025)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(20161123561025)(20161123559100); SRVR:CY4PR03MB2792; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2792; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2792; 4:XXEDKS13GYJGG467b56HUbax5sP2YNGw1cBx8OWCeD?= qdEOyrP5rl1TO6+OnO5zLShiszG8dZfpA+lFBMfIgRydDWtLa8CqGmg1IvxGkgRRJAJONF+FXvIxD14LcvckGvjpxNn8uI1mkp6FTS84EyT1do1C7M03jOVhfVUYsdBPWzCpRmL5a+RIhblVfPRSTyKc/qelvI1d0LKDvWwGIQ55MpZDtNi3066HcUbS8Noa7Tf/QhCAeu9NAclH+Lg1T8GEQKD1hplk09rZxi534i0+fC9I8haADJnov7KRJgiI+HCe8zUq0ZuaYndNC2GfajZbIOWJzrcLchZFxvAoggAjQS8xx6xIc2Q9pa+YbrxY5osA4tZZkIeic3NGo572FV8r63r8DE0Q8a2OqiCrYmsCBRZB3mvjWVdXAAxpyuyP/g8SpRxRipFfEEnS20uVycq+LZU3ipLcu68AGChdI6wzm1iY9tRgO5J6eq8X+Nz9VmNb+y6inYG8E8+wKBMnAjmAVz+ukqj15BUM4CafZFKIziI9eRwQaza1NX94IUcjV3ZyZKoGAWbpRy2SWxe2rORNEO6J7qHlAZltMPkbYfu1/cihsG5JJiHh1lJEwHCmnK0iPlLKWaM6b/jqsUwblYMVvuUEwp8VNA5afAPEsqFrUuwLZZIPFlyR5Fj5+mBXKQIni+RgPOAcflPzJsPjhl16MQeA+1vFtnn+JHtLupCL1uzQbIN4Og9Ob5b6hpzL2UrCtA/1riIRP/hgfuerzlI/BWPEfGSNKYwQ6x0WM2vdPA7rhBumrfm1jOrsrEtQNtIn4w4T6nixhDd+QQlL3VOuH9GookEnIPGDExaYyXp0jITcJA+Z6phN5IFG3ofthtHBf3R7M6Cc/fs9AjJN68Kp2D3xhhn8/kZh2IxOkws54dTUeFv5RAOvKsnBt9PjdBDS6tB3EUGCQ7vbP+m7spaQKX4LgfTG1JOaYsU3GGsQ== X-Forefront-PRVS: 0316567485 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2792; 23:6qdGnL8O1blBiGj9iVeUwxxgAy8oEZDI3hQDbmBxB?= Q9Ne4V2KtB4zDt+tHTaGfVDVbNLqKHjC0aMIL/pFd4cEMOS569KYC3ejvGTsuX24tr1U9KRpxHXHOg9wenaeMQV6cN4BBZR2PvvEmg7Wh3v5kLVOF002KjI1xgAK3RuN0DWl/wSG9qc8gjPdAlKp73kRA7qb1euBdfjy3wEAC7Z0cI8RIwreud/Tkzv8unYflrEYbQwSX7Sck9hS38IncnLlxTD0yH79qa3OoykildzX8+O5ga+Wmr92lqLqecFUaWldJHIrxk9q1W/VSEtoy/VmqOslbAJzvWGqJeeCQQVYGeEq2+nI4bHLeeROKMfqQ1LlMk2wqyR/SH+qVRuBTV9ZgpbTVmndfMfoZ0Q7UP97egUgJKDfyl3kXejMVNUT5977WiYTmlkI8hMW1Vfj0IMqNgKUUvzAklGOe3fD5lEAOpA1/2sH9EdCyCcANexeBmiUMGaRDYgHPsFaANxqm+8TRHqZVmuemmSCWh94y/N7Dz5E904DQXisijaHlNtsAfV3lFTDGtXjWGRl03j9wu4+xTB3q9XMJFZPkGAO9tXUkorRfRZAqmMtGA5alweoyo7uu65EwmIwFCXE/tVWGWxBz7PTGCcj49gcrtWhDrV2bfrt+kkvKwdi4hAVf8UN2FESiyXGBibSVPgf1khsxYPvY3d3ZJLQqIXe6r0E5sQbrD27rdfJ3WsfkrhxLdROIj3JEKnit74xL0/x1hnexO3RNOkfgS0jwfQtY/FFUZ9/l5AeNHAgSHcbt4kr6U9+jQYL13/CpPKSQrW66Yatt1Qe8VL16xdCiOP+2ZAu33iaM14EhYhIExEhf0taZBdUTYmARFRmldSa4BIUexubWaWsFtvEhrqjxDJg7UovMZruqm059YbRJcOgKrfExv5p0oZ67f3zbldqxKqlq/MG+/gKC2QYwwfNhYgzimVomhSJMTNxWtn15E668IcGLasZR68c1o+4Lzhz/v1kWNaA3KN7YOJ3RyWyJ+k3WDADx116TQ0xBnRm4HLykUplTxw7pWoQiS0EwY7U9H2Vft9T47zpC7pafonyeS+8aRwiidxQWj/zyCIFzAKu/3ZTCzbZblahzOf8wpLSXx4ywPIkPE6uxeG7W2zXY+Y4Uoyz/A/1kf6Ov6UJFYTpWlgAlZps0tp+uPNWeJNGsO3O9sUAukq+P/vVTJe/kpOtFinIrkNP2J8tvRaqftAu6xjp9ptk1w= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 6:uchIp3nrWs8xrWraO1uTPK/0/f35qfmuOjHrgKPdJqTbgTgP2I7dpPvhUEv5rhwZNOCo2HFxE0fYQmWJ/Nd7AIO6vQnYBFeTCEwcYcKkPWdINTPO4j2KwtptZ6/IYbxoXl7OvVR50XeoWnuUAuyrwVD3HG5xL1Tr1PtcU7B5dlfHsHxCAWSftcFr53PCYKpBEi9I1cQzcDip0hCGmNcdSuGr3W/ntk6ttiM2N4YjSeSGlxSAzkLSvgEGiTF3ZI+OCuZFN0OOhhJZHinergUWKyLzpMtM/fi2rUlwVCcIogzjrkoQZ7fd2E1fjJdkZNEDY2TcOqa+78WfBcAilX8689MoJmm4TM3ZwOgSBNgHVV5ul4VzHEbhuquOed3Q8ZvFSSq+PpLz8ujPpSlx+BpVEn0sIWpUlRYGDQnyjaHKzycsACdE3x6Bvg+6k/w8JwEWIt8LkmSc+7Byxbg5uR5WTDbz5tV8eFgmmEP/rEnwMOBwgvfTI9wot7OgGnif2M34OAK4ODmxffx52BD8jf3BTg==; 5:XYPz30C8b7JDT79mLowbIr8ANAiTq/e6sxZUy+cdzUCcY/IMPsrD2rfs1QkcZGZiS74AV+sQs4djZ+tPLWjZDfzW7GNwFu4R5sz6eA5KGA7mfLgZfeqnxeU0+EhmY/ez4XaFPBgehanPKDUv6ZykBCAGLrX5bv9bFG3mLgxTEZm4i5tmUtetIKC+4aU9R3OZ; 24:8itKMODkPD0Mw6hJPqv7xr6YVWer8yGxSQw3cXuAjW/p1sPMDT2e+hSSi/mcD77Z6J73cUVeyIJHydrBIImoN+sOE5rmEkg5y+CDlfmAajc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 7:asF+EX+KcsqetK2ndeLCncGE0tsjCwn9KAzAaKk3q2bmpHYIRrJ/ILTzdNXCGD7DOyyXoMkPFq6367gQBM0vTePkRdQhmcYWIetReuT0fWC0ZqOa8UTNCQ1vPeyPrXv0m7n9mTOJAaZ6d1cxhtookGlRatbLHEZc4Md5gECuRbsszrX7C2rLlRmUbw1nIK1Lj1johoEJxRksvvZBbn6C6bB6bjMSuUR9hWhSNwxftbEA8py03rou0GYFmKyrRzuisqw11Qal1Dzw45X57Is9EgO58AGLP+gBVukeGtZ5jMZPxCCxgdHVtFNyvJJ5h9T31ot7KAFrrMFKZKwno+3+qw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2017 09:34:11.5992 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2792 Subject: [dpdk-dev] [PATCH 2/2] mempool/dpaa2: improving the alloc/free logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Hemant Agrawal
May 23, 2017, 9:33 a.m. UTC
Debug logs are helpful for better debugging. Alloc
was having the logs, but logs were not present in free routines.
This patch add support for debug mode logs in free routine.
Also, changing the log category to DRV instead of TX.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Comments
Hi Hemant, On Tue, 23 May 2017 15:03:48 +0530, Hemant Agrawal <hemant.agrawal@nxp.com> wrote: > Debug logs are helpful for better debugging. Alloc > was having the logs, but logs were not present in free routines. > > This patch add support for debug mode logs in free routine. > Also, changing the log category to DRV instead of TX. > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- > drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > index 60dd1c0..e00ed5d 100644 > --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c > @@ -309,8 +309,8 @@ > > #ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER > alloc += n; > - PMD_TX_LOG(DEBUG, "Total = %d , req = %d done = %d", > - alloc, count, n); > + PMD_DRV_LOG(DEBUG, "Total = %d , req = %d done = %d", > + alloc, count, n); > #endif > return 0; > } Since we are in a mempool driver, we may not want to use PMD_*_LOG() functions. Also, I don't see where these macros are defined for this file, but maybe I miss something that is right under my nose ;) Anyway, I suggest to use your own macros for dpaa mempool instead, and if possible: - avoid compilation options as much as possible - RTE_LOG() for logs that cannot occur in dataplane (they can be enabled dynamically) - RTE_LOG_DP() for dataplane logs: these are stripped at compilation time, unless your log level <= RTE_LOG_DP_LEVEL > @@ -320,6 +320,9 @@ > void * const *obj_table, unsigned int n) > { > struct dpaa2_bp_info *bp_info; > +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER > + static int freed; > +#endif > > bp_info = mempool_to_bpinfo(pool); > if (!(bp_info->bp_list)) { > @@ -329,6 +332,11 @@ > rte_dpaa2_mbuf_release(pool, obj_table, bp_info->bpid, > bp_info->meta_data_size, n); > > +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER > + freed += n; > + PMD_DRV_LOG(DEBUG, "Total = %d , done = %d", > + freed, n); > +#endif > return 0; > } >
On 6/8/2017 3:38 PM, Olivier Matz wrote: > Hi Hemant, > > On Tue, 23 May 2017 15:03:48 +0530, Hemant Agrawal <hemant.agrawal@nxp.com> wrote: >> Debug logs are helpful for better debugging. Alloc >> was having the logs, but logs were not present in free routines. >> >> This patch add support for debug mode logs in free routine. >> Also, changing the log category to DRV instead of TX. >> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> >> --- >> drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c >> index 60dd1c0..e00ed5d 100644 >> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c >> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c >> @@ -309,8 +309,8 @@ >> >> #ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER >> alloc += n; >> - PMD_TX_LOG(DEBUG, "Total = %d , req = %d done = %d", >> - alloc, count, n); >> + PMD_DRV_LOG(DEBUG, "Total = %d , req = %d done = %d", >> + alloc, count, n); >> #endif >> return 0; >> } > > Since we are in a mempool driver, we may not want to use PMD_*_LOG() > functions. > > Also, I don't see where these macros are defined for this file, but maybe > I miss something that is right under my nose ;) > These are being currently being driven from the bus logs. > Anyway, I suggest to use your own macros for dpaa mempool instead, > and if possible: > - avoid compilation options as much as possible > - RTE_LOG() for logs that cannot occur in dataplane (they can be enabled > dynamically) > - RTE_LOG_DP() for dataplane logs: these are stripped at compilation > time, unless your log level <= RTE_LOG_DP_LEVEL > your suggestion is good. I will rework the whole file and submit it later. > >> @@ -320,6 +320,9 @@ >> void * const *obj_table, unsigned int n) >> { >> struct dpaa2_bp_info *bp_info; >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER >> + static int freed; >> +#endif >> >> bp_info = mempool_to_bpinfo(pool); >> if (!(bp_info->bp_list)) { >> @@ -329,6 +332,11 @@ >> rte_dpaa2_mbuf_release(pool, obj_table, bp_info->bpid, >> bp_info->meta_data_size, n); >> >> +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER >> + freed += n; >> + PMD_DRV_LOG(DEBUG, "Total = %d , done = %d", >> + freed, n); >> +#endif >> return 0; >> } >> > >
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 60dd1c0..e00ed5d 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -309,8 +309,8 @@ #ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER alloc += n; - PMD_TX_LOG(DEBUG, "Total = %d , req = %d done = %d", - alloc, count, n); + PMD_DRV_LOG(DEBUG, "Total = %d , req = %d done = %d", + alloc, count, n); #endif return 0; } @@ -320,6 +320,9 @@ void * const *obj_table, unsigned int n) { struct dpaa2_bp_info *bp_info; +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER + static int freed; +#endif bp_info = mempool_to_bpinfo(pool); if (!(bp_info->bp_list)) { @@ -329,6 +332,11 @@ rte_dpaa2_mbuf_release(pool, obj_table, bp_info->bpid, bp_info->meta_data_size, n); +#ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER + freed += n; + PMD_DRV_LOG(DEBUG, "Total = %d , done = %d", + freed, n); +#endif return 0; }