[dpdk-dev] net/avp: remove redundant assignment

Message ID 20170525175246.95118-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit May 25, 2017, 5:52 p.m. UTC
  dev_info->driver_name is assigned by rte_eth_dev_info_get()
and existing value overwritten, removing assignment.

Fixes: 1a85922369c4 ("net/avp: add device configuration")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/avp/avp_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Allain Legacy May 26, 2017, 1:05 p.m. UTC | #1
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, May 25, 2017 1:53 PM
> To: Legacy, Allain; Peters, Matt
> Cc: dev@dpdk.org; YIGIT, FERRUH
> Subject: [PATCH] net/avp: remove redundant assignment
> 
> dev_info->driver_name is assigned by rte_eth_dev_info_get() and existing
> value overwritten, removing assignment.
> 
> Fixes: 1a85922369c4 ("net/avp: add device configuration")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Acked-by: Allain Legacy <allain.legacy@windriver.com>
  
Ferruh Yigit May 26, 2017, 4:17 p.m. UTC | #2
On 5/26/2017 2:05 PM, Legacy, Allain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Thursday, May 25, 2017 1:53 PM
>> To: Legacy, Allain; Peters, Matt
>> Cc: dev@dpdk.org; YIGIT, FERRUH
>> Subject: [PATCH] net/avp: remove redundant assignment
>>
>> dev_info->driver_name is assigned by rte_eth_dev_info_get() and existing
>> value overwritten, removing assignment.
>>
>> Fixes: 1a85922369c4 ("net/avp: add device configuration")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
> Acked-by: Allain Legacy <allain.legacy@windriver.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 3554645..c746a0e 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -2202,7 +2202,6 @@  avp_dev_info_get(struct rte_eth_dev *eth_dev,
 {
 	struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
 
-	dev_info->driver_name = "rte_avp_pmd";
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
 	dev_info->max_rx_queues = avp->max_rx_queues;
 	dev_info->max_tx_queues = avp->max_tx_queues;