diff mbox

[dpdk-dev] kni: fix compilation under RHEL 7.4.

Message ID 1496245215-3859-1-git-send-email-lee.roberts@hpe.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Lee Roberts May 31, 2017, 3:40 p.m. UTC 
  Fix kni compilation under RHEL 7.4.

Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
---
 lib/librte_eal/linuxapp/kni/compat.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit May 31, 2017, 4:43 p.m. UTC | #1 
On 5/31/2017 4:40 PM, Lee Roberts wrote:
> Fix kni compilation under RHEL 7.4.
> 
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>

Not tested on RHEL 7.4, but patch looks good to me except following
nit-picking:
- There should not be "." at the end of the patch title
- It can be good to add Linux commit that is the reason of the change to
the commit log:
Linux: 9b36627acecd ("net: remove dev->trans_start")

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon June 5, 2017, 1:46 p.m. UTC | #2 
31/05/2017 18:43, Ferruh Yigit:
> On 5/31/2017 4:40 PM, Lee Roberts wrote:
> > Fix kni compilation under RHEL 7.4.
> > 
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> 
> Not tested on RHEL 7.4, but patch looks good to me except following
> nit-picking:
> - There should not be "." at the end of the patch title
> - It can be good to add Linux commit that is the reason of the change to
> the commit log:
> Linux: 9b36627acecd ("net: remove dev->trans_start")
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
index d96275a..6a1587b 100644
--- a/lib/librte_eal/linuxapp/kni/compat.h
+++ b/lib/librte_eal/linuxapp/kni/compat.h
@@ -53,7 +53,9 @@ 
 #define HAVE_SK_ALLOC_KERN_PARAM
 #endif
 
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0) || \
+	(defined(RHEL_RELEASE_CODE) && \
+	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))
 #define HAVE_TRANS_START_HELPER
 #endif