diff mbox

[dpdk-dev] ethdev: fix ethdev start return value

Message ID 1496831648-28048-1-git-send-email-pbhagavatula@caviumnetworks.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Pavan Nikhilesh June 7, 2017, 10:34 a.m. UTC 
  From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>

If ethdev has already started it should return -EBUSY instead of 0 when
rte_eth_dev_start is called.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 lib/librte_ether/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon July 5, 2017, 5:32 p.m. UTC | #1 
07/06/2017 12:34, Pavan Nikhilesh:
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
> 
> If ethdev has already started it should return -EBUSY instead of 0 when
> rte_eth_dev_start is called.

It is an API change and must be announced in a deprecation notice.

>  lib/librte_ether/rte_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please update the doxygen in .h.
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index d257406..00f1a8c 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -909,7 +909,7 @@  rte_eth_dev_start(uint8_t port_id)
 		RTE_PMD_DEBUG_TRACE("Device with port_id=%" PRIu8
 			" already started\n",
 			port_id);
-		return 0;
+		return -EBUSY;
 	}
 
 	diag = (*dev->dev_ops->dev_start)(dev);