diff mbox

[dpdk-dev,v2,06/12] cryptodev: disabled by default

Message ID 1b9434af8872a0fa468618835c34e255e9c76c36.1496877060.git.gaetan.rivet@6wind.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gaëtan Rivet June 7, 2017, 11:59 p.m. UTC 
  Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 config/common_base | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo June 9, 2017, 3:03 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> Sent: Thursday, June 08, 2017 12:59 AM
> To: dev@dpdk.org
> Cc: Gaetan Rivet
> Subject: [dpdk-dev] [PATCH v2 06/12] cryptodev: disabled by default
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  config/common_base | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/common_base b/config/common_base
> index 0e0b732..cade611 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -430,7 +430,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
>  #
>  # Compile generic crypto device library
>  #
> -CONFIG_RTE_LIBRTE_CRYPTODEV=y
> +CONFIG_RTE_LIBRTE_CRYPTODEV=n
>  CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
>  CONFIG_RTE_CRYPTO_MAX_DEVS=64
>  CONFIG_RTE_CRYPTODEV_NAME_LEN=64
> --
> 2.1.4

As already discussed, there should be no need to disable this,
after applying this: http://dpdk.org/ml/archives/dev/2017-May/066382.html
Gaëtan Rivet June 14, 2017, 8 a.m. UTC | #2 
Hi Pablo,

On Fri, Jun 09, 2017 at 03:03:08PM +0000, De Lara Guarch, Pablo wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> > Sent: Thursday, June 08, 2017 12:59 AM
> > To: dev@dpdk.org
> > Cc: Gaetan Rivet
> > Subject: [dpdk-dev] [PATCH v2 06/12] cryptodev: disabled by default
> > 
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> >  config/common_base | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/config/common_base b/config/common_base
> > index 0e0b732..cade611 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -430,7 +430,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
> >  #
> >  # Compile generic crypto device library
> >  #
> > -CONFIG_RTE_LIBRTE_CRYPTODEV=y
> > +CONFIG_RTE_LIBRTE_CRYPTODEV=n
> >  CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
> >  CONFIG_RTE_CRYPTO_MAX_DEVS=64
> >  CONFIG_RTE_CRYPTODEV_NAME_LEN=64
> > --
> > 2.1.4
> 
> As already discussed, there should be no need to disable this,
> after applying this: http://dpdk.org/ml/archives/dev/2017-May/066382.html
> 

Just to confirm, once properly applied, your patchset fixes the issue. I
will remove this patch from the next version and update the dependencies
to include your patchset.
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 0e0b732..cade611 100644
--- a/config/common_base
+++ b/config/common_base
@@ -430,7 +430,7 @@  CONFIG_RTE_PMD_PACKET_PREFETCH=y
 #
 # Compile generic crypto device library
 #
-CONFIG_RTE_LIBRTE_CRYPTODEV=y
+CONFIG_RTE_LIBRTE_CRYPTODEV=n
 CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
 CONFIG_RTE_CRYPTO_MAX_DEVS=64
 CONFIG_RTE_CRYPTODEV_NAME_LEN=64