diff mbox

[dpdk-dev] app/testpmd: fix the comments in source file cmdline

Message ID 201706160136.v5G1aKcN084193@mse01.zte.com.cn (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Xie RongQiang June 15, 2017, 10:20 a.m. UTC 
  Because the comments in function cmd_add_bonding_slave_parsed() and
cmd_remove_bonding_slave_parsed() is 'Set the primary slave for
a bonded device',so fix it with 'add the slave for a bonded device'
and 'remove the slave from a bonded device'.

Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jingjing Wu June 19, 2017, 1:12 a.m. UTC | #1 
> -----Original Message-----
> From: RongQiang Xie [mailto:xie.rongqiang@zte.com.cn]
> Sent: Thursday, June 15, 2017 6:21 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; RongQiang Xie <xie.rongqiang@zte.com.cn>
> Subject: [PATCH] app/testpmd: fix the comments in source file cmdline
> 
> Because the comments in function cmd_add_bonding_slave_parsed() and
> cmd_remove_bonding_slave_parsed() is 'Set the primary slave for a bonded
> device',so fix it with 'add the slave for a bonded device'
> and 'remove the slave from a bonded device'.
> 
> Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>

Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Thanks
Jingjing
Thomas Monjalon July 3, 2017, 8:58 a.m. UTC | #2 
> > Because the comments in function cmd_add_bonding_slave_parsed() and
> > cmd_remove_bonding_slave_parsed() is 'Set the primary slave for a bonded
> > device',so fix it with 'add the slave for a bonded device'
> > and 'remove the slave from a bonded device'.
> > 
> > Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0afac68..c1d8755 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4546,7 +4546,7 @@  static void cmd_add_bonding_slave_parsed(void *parsed_result,
 	portid_t master_port_id = res->port_id;
 	portid_t slave_port_id = res->slave_id;
 
-	/* Set the primary slave for a bonded device. */
+	/* add the slave for a bonded device. */
 	if (0 != rte_eth_bond_slave_add(master_port_id, slave_port_id)) {
 		printf("\t Failed to add slave %d to master port = %d.\n",
 				slave_port_id, master_port_id);
@@ -4604,7 +4604,7 @@  static void cmd_remove_bonding_slave_parsed(void *parsed_result,
 	portid_t master_port_id = res->port_id;
 	portid_t slave_port_id = res->slave_id;
 
-	/* Set the primary slave for a bonded device. */
+	/* remove the slave from a bonded device. */
 	if (0 != rte_eth_bond_slave_remove(master_port_id, slave_port_id)) {
 		printf("\t Failed to remove slave %d from master port = %d.\n",
 				slave_port_id, master_port_id);