[dpdk-dev,v3] cxgbe: report 100G link speed capability for Chelsio T6 adapters

Message ID 1498126047-44989-1-git-send-email-martin.weiser@allegro-packets.com (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Martin Weiser June 22, 2017, 10:07 a.m. UTC
  These adapters support 100G link speed but the speed_capa bitmask in the
device info did not reflect that.

Signed-off-by: Martin Weiser <martin.weiser@allegro-packets.com>
---
 drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Rahul Lakkireddy June 23, 2017, 5:36 a.m. UTC | #1
Hi Martin,

On Thursday, June 06/22/17, 2017 at 15:37:27 +0530, Martin Weiser wrote:
>    These adapters support 100G link speed but the speed_capa bitmask in the
>    device info did not reflect that.
> 
>    Signed-off-by: Martin Weiser <martin.weiser@allegro-packets.com>
>    ---
>     drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++
>     1 file changed, 3 insertions(+)
> 
>    diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c
>    b/drivers/net/cxgbe/cxgbe_ethdev.c
>    index b622d25..1e56529 100644
>    --- a/drivers/net/cxgbe/cxgbe_ethdev.c
>    +++ b/drivers/net/cxgbe/cxgbe_ethdev.c
>    @@ -176,6 +176,9 @@ static void cxgbe_dev_info_get(struct rte_eth_dev
>    *eth_dev,
>             device_info->rx_desc_lim = cxgbe_desc_lim;
>             device_info->tx_desc_lim = cxgbe_desc_lim;
>             device_info->speed_capa = ETH_LINK_SPEED_10G |
>    ETH_LINK_SPEED_40G;
>    +
>    +       if (CHELSIO_CHIP_VERSION(adapter->params.chip) == CHELSIO_T6)
>    +               device_info->speed_capa |= ETH_LINK_SPEED_100G;
>     }
>     
>     static void cxgbe_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)
>    --
>    2.7.4

Thanks for the patch.  However, not all Chelsio T6 adapters support
10G/40G/100G link speeds at the same time.  I have a patch to report
the supported link speeds correctly and is currently undergoing testing.
I will submit the patch very soon.

Thanks,
Rahul
  

Patch

diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index b622d25..1e56529 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -176,6 +176,9 @@  static void cxgbe_dev_info_get(struct rte_eth_dev *eth_dev,
 	device_info->rx_desc_lim = cxgbe_desc_lim;
 	device_info->tx_desc_lim = cxgbe_desc_lim;
 	device_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_40G;
+
+	if (CHELSIO_CHIP_VERSION(adapter->params.chip) == CHELSIO_T6)
+		device_info->speed_capa |= ETH_LINK_SPEED_100G;
 }
 
 static void cxgbe_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)