[dpdk-dev,5/5] event/octeontx: add enqueue fwd op variant

Message ID 20170629141956.23132-5-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob June 29, 2017, 2:19 p.m. UTC
  Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 drivers/event/octeontx/ssovf_evdev.c  |  2 +-
 drivers/event/octeontx/ssovf_evdev.h  |  2 ++
 drivers/event/octeontx/ssovf_worker.c | 12 ++++++++++++
 3 files changed, 15 insertions(+), 1 deletion(-)
  

Comments

Eads, Gage June 30, 2017, 2:20 a.m. UTC | #1
Hi Jerin,

This patch set looks good. For the series:
Acked-by: Gage Eads <gage.eads@intel.com>

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Thursday, June 29, 2017 9:20 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage
> <gage.eads@intel.com>; nipun.gupta@nxp.com; Vangati, Narender
> <narender.vangati@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH 5/5] event/octeontx: add enqueue fwd op variant
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  drivers/event/octeontx/ssovf_evdev.c  |  2 +-
> drivers/event/octeontx/ssovf_evdev.h  |  2 ++
> drivers/event/octeontx/ssovf_worker.c | 12 ++++++++++++
>  3 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/event/octeontx/ssovf_evdev.c
> b/drivers/event/octeontx/ssovf_evdev.c
> index 3cd0cd49d..eb349f60d 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -159,7 +159,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev)
>  	dev->enqueue       = ssows_enq;
>  	dev->enqueue_burst = ssows_enq_burst;
>  	dev->enqueue_new_burst = ssows_enq_new_burst;
> -	dev->enqueue_forward_burst = ssows_enq_burst;
> +	dev->enqueue_forward_burst = ssows_enq_fwd_burst;
>  	dev->dequeue       = ssows_deq;
>  	dev->dequeue_burst = ssows_deq_burst;
> 
> diff --git a/drivers/event/octeontx/ssovf_evdev.h
> b/drivers/event/octeontx/ssovf_evdev.h
> index 47091a46e..3b8c23e3a 100644
> --- a/drivers/event/octeontx/ssovf_evdev.h
> +++ b/drivers/event/octeontx/ssovf_evdev.h
> @@ -192,6 +192,8 @@ uint16_t ssows_enq_burst(void *port,
>  		const struct rte_event ev[], uint16_t nb_events);  uint16_t
> ssows_enq_new_burst(void *port,
>  		const struct rte_event ev[], uint16_t nb_events);
> +uint16_t ssows_enq_fwd_burst(void *port,
> +		const struct rte_event ev[], uint16_t nb_events);
>  uint16_t ssows_deq(void *port, struct rte_event *ev, uint64_t timeout_ticks);
> uint16_t ssows_deq_burst(void *port, struct rte_event ev[],
>  		uint16_t nb_events, uint64_t timeout_ticks); diff --git
> a/drivers/event/octeontx/ssovf_worker.c
> b/drivers/event/octeontx/ssovf_worker.c
> index 5393febba..4d413d779 100644
> --- a/drivers/event/octeontx/ssovf_worker.c
> +++ b/drivers/event/octeontx/ssovf_worker.c
> @@ -213,6 +213,18 @@ ssows_enq_new_burst(void *port, const struct
> rte_event ev[], uint16_t nb_events)
> 
>  	return nb_events;
>  }
> +
> +uint16_t __hot
> +ssows_enq_fwd_burst(void *port, const struct rte_event ev[], uint16_t
> +nb_events) {
> +	struct ssows *ws = port;
> +	RTE_SET_USED(nb_events);
> +
> +	ssows_forward_event(ws,  ev);
> +
> +	return 1;
> +}
> +
>  void
>  ssows_flush_events(struct ssows *ws, uint8_t queue_id)  {
> --
> 2.13.2
  
Jerin Jacob July 1, 2017, 12:56 p.m. UTC | #2
-----Original Message-----
> Date: Fri, 30 Jun 2017 02:20:34 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> CC: "Richardson, Bruce" <bruce.richardson@intel.com>, "Van Haaren, Harry"
>  <harry.van.haaren@intel.com>, "hemant.agrawal@nxp.com"
>  <hemant.agrawal@nxp.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
>  "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
>  <nikhil.rao@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 5/5] event/octeontx: add enqueue fwd op
>  variant
> 
> Hi Jerin,
> 
> This patch set looks good. For the series:
> Acked-by: Gage Eads <gage.eads@intel.com>


Applied the series to dpdk-next-eventdev/master.

Added the following lines in "just merged(NXP PMD)" to adapt to this change.

+eventdev->enqueue_new_burst = dpaa2_eventdev_enqueue_burst;
+eventdev->enqueue_forward_burst = dpaa2_eventdev_enqueue_burst;

Thanks
  

Patch

diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
index 3cd0cd49d..eb349f60d 100644
--- a/drivers/event/octeontx/ssovf_evdev.c
+++ b/drivers/event/octeontx/ssovf_evdev.c
@@ -159,7 +159,7 @@  ssovf_fastpath_fns_set(struct rte_eventdev *dev)
 	dev->enqueue       = ssows_enq;
 	dev->enqueue_burst = ssows_enq_burst;
 	dev->enqueue_new_burst = ssows_enq_new_burst;
-	dev->enqueue_forward_burst = ssows_enq_burst;
+	dev->enqueue_forward_burst = ssows_enq_fwd_burst;
 	dev->dequeue       = ssows_deq;
 	dev->dequeue_burst = ssows_deq_burst;
 
diff --git a/drivers/event/octeontx/ssovf_evdev.h b/drivers/event/octeontx/ssovf_evdev.h
index 47091a46e..3b8c23e3a 100644
--- a/drivers/event/octeontx/ssovf_evdev.h
+++ b/drivers/event/octeontx/ssovf_evdev.h
@@ -192,6 +192,8 @@  uint16_t ssows_enq_burst(void *port,
 		const struct rte_event ev[], uint16_t nb_events);
 uint16_t ssows_enq_new_burst(void *port,
 		const struct rte_event ev[], uint16_t nb_events);
+uint16_t ssows_enq_fwd_burst(void *port,
+		const struct rte_event ev[], uint16_t nb_events);
 uint16_t ssows_deq(void *port, struct rte_event *ev, uint64_t timeout_ticks);
 uint16_t ssows_deq_burst(void *port, struct rte_event ev[],
 		uint16_t nb_events, uint64_t timeout_ticks);
diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c
index 5393febba..4d413d779 100644
--- a/drivers/event/octeontx/ssovf_worker.c
+++ b/drivers/event/octeontx/ssovf_worker.c
@@ -213,6 +213,18 @@  ssows_enq_new_burst(void *port, const struct rte_event ev[], uint16_t nb_events)
 
 	return nb_events;
 }
+
+uint16_t __hot
+ssows_enq_fwd_burst(void *port, const struct rte_event ev[], uint16_t nb_events)
+{
+	struct ssows *ws = port;
+	RTE_SET_USED(nb_events);
+
+	ssows_forward_event(ws,  ev);
+
+	return 1;
+}
+
 void
 ssows_flush_events(struct ssows *ws, uint8_t queue_id)
 {