diff mbox

[dpdk-dev,v4,4/5] app/testpmd: display PCI address in port info

Message ID 1498748282-69914-5-git-send-email-wei.dai@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wei Dai June 29, 2017, 2:58 p.m. UTC 
  Add the PCI address when running "show port info port_id".

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 app/test-pmd/config.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jingjing Wu June 30, 2017, 9:07 a.m. UTC | #1 
> -----Original Message-----
> From: Dai, Wei
> Sent: Thursday, June 29, 2017 10:58 PM
> To: thomas@monjalon.net; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; yuan.pntel.com
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH v4 4/5] app/testpmd: display PCI address in port info
> 
> Add the PCI address when running "show port info port_id".
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  app/test-pmd/config.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index b0b340e..c2d5c03 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -438,6 +438,11 @@ port_infos_display(portid_t port_id)
>  	rte_eth_dev_info_get(port_id, &dev_info);
>  	printf("\n%s Infos for port %-2d %s\n",
>  	       info_border, port_id, info_border);
> +	printf("PCI Address: " PCI_PRI_FMT "\n",
> +		dev_info.pci_dev->addr.domain,
> +		dev_info.pci_dev->addr.bus,
> +		dev_info.pci_dev->addr.devid,
> +		dev_info.pci_dev->addr.function);
>  	rte_eth_macaddr_get(port_id, &mac_addr);
>  	print_ethaddr("MAC address: ", &mac_addr);
>  	printf("\nDriver name: %s", dev_info.driver_name);
> --
> 2.7.4

The field pci_dev will probably be removed.
Yulong already submit a patch like this and rejected.
http://www.dpdk.org/dev/patchwork/patch/23899/

So, you can add more info when the Bus refine work is done.
You can drop this change from your patch set.

Thanks
Jingjing
diff mbox

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index b0b340e..c2d5c03 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -438,6 +438,11 @@  port_infos_display(portid_t port_id)
 	rte_eth_dev_info_get(port_id, &dev_info);
 	printf("\n%s Infos for port %-2d %s\n",
 	       info_border, port_id, info_border);
+	printf("PCI Address: " PCI_PRI_FMT "\n",
+		dev_info.pci_dev->addr.domain,
+		dev_info.pci_dev->addr.bus,
+		dev_info.pci_dev->addr.devid,
+		dev_info.pci_dev->addr.function);
 	rte_eth_macaddr_get(port_id, &mac_addr);
 	print_ethaddr("MAC address: ", &mac_addr);
 	printf("\nDriver name: %s", dev_info.driver_name);