diff mbox

[dpdk-dev] app/testpmd:add bond type description

Message ID 201706300158.v5U1wmLt087572@mse01.zte.com.cn (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation fail apply patch file failure

Commit Message

Xie RongQiang June 30, 2017, 1:52 a.m. UTC 
  In function  cmd_show_bonding_config_parsed() use number
represent the bond type,in order more detailed,add bond
type description otherwise we may confused about the number
type.
And also,The primary port just use in mode active backup
and tlb,so,when the mode is the active backup or tlb we
show the primary port info.

Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
---
 app/test-pmd/cmdline.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Doherty, Declan June 30, 2017, 1:47 p.m. UTC | #1 
On 30/06/2017 2:52 AM, RongQiang Xie wrote:
> In function  cmd_show_bonding_config_parsed() use number
> represent the bond type,in order more detailed,add bond
> type description otherwise we may confused about the number
> type.
> And also,The primary port just use in mode active backup
> and tlb,so,when the mode is the active backup or tlb we
> show the primary port info.
>
> Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
> ---
>  app/test-pmd/cmdline.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 4eac498..1ae5fc0 100755
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4455,6 +4455,7 @@ static void cmd_show_bonding_config_parsed(void *parsed_result,
>  		printf("\tActive Slaves: []\n");
>
>  	}
> +	
>  	if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP ||
>  		bonding_mode == BONDING_MODE_TLB) {
>  		primary_id = rte_eth_bond_primary_get(port_id);
>

Hey, I think you are missing some of your intended changes in this 
patch? I'm only seeing a white space addition. Also the body of your 
email seems to be merged with the emails subject line.

Thanks
Declan
Doherty, Declan June 30, 2017, 1:52 p.m. UTC | #2 
On 30/06/2017 2:47 PM, Declan Doherty wrote:
> On 30/06/2017 2:52 AM, RongQiang Xie wrote:
>> In function  cmd_show_bonding_config_parsed() use number
>> represent the bond type,in order more detailed,add bond
>> type description otherwise we may confused about the number
>> type.
>> And also,The primary port just use in mode active backup
>> and tlb,so,when the mode is the active backup or tlb we
>> show the primary port info.
>>
>> Signed-off-by: RongQiang Xie <xie.rongqiang@zte.com.cn>
>> ---
>>  app/test-pmd/cmdline.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 4eac498..1ae5fc0 100755
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -4455,6 +4455,7 @@ static void cmd_show_bonding_config_parsed(void
>> *parsed_result,
>>          printf("\tActive Slaves: []\n");
>>
>>      }
>> +
>>      if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP ||
>>          bonding_mode == BONDING_MODE_TLB) {
>>          primary_id = rte_eth_bond_primary_get(port_id);
>>
>
> Hey, I think you are missing some of your intended changes in this
> patch? I'm only seeing a white space addition. Also the body of your
> email seems to be merged with the emails subject line.
>
> Thanks
> Declan

Sorry you can disregard above. It seems that my email client (Mozilla 
Thunderbird) is having difficultly with some of the characters in the 
email and isn't rendering it correctly for me, your patches look fine in 
patchwork, so I'll review from there.

Declan
diff mbox

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 4eac498..1ae5fc0 100755
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4455,6 +4455,7 @@  static void cmd_show_bonding_config_parsed(void *parsed_result,
 		printf("\tActive Slaves: []\n");
 
 	}
+	
 	if (bonding_mode == BONDING_MODE_ACTIVE_BACKUP ||
 		bonding_mode == BONDING_MODE_TLB) {
 		primary_id = rte_eth_bond_primary_get(port_id);