diff mbox

[dpdk-dev,v2,7/8] net/qede: add missing check for VNI

Message ID 1498937402-25547-8-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh July 1, 2017, 7:30 p.m. UTC 
  Add missing check for VNI field while adding unicast filter.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 drivers/net/qede/qede_ethdev.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit July 3, 2017, 10:08 a.m. UTC | #1 
On 7/1/2017 8:30 PM, Rasesh Mody wrote:
> Add missing check for VNI field while adding unicast filter.

Can you please document the result of not having vni field? And if this
is fixing an error, can you please use fixes syntax?

> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
>  drivers/net/qede/qede_ethdev.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ad264ba..a0616a4 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -571,6 +571,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn,
>  		SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
>  			if ((memcmp(mac_addr, &tmp->mac,
>  				    ETHER_ADDR_LEN) == 0) &&
> +			     ucast->vni == tmp->vni &&
>  			     ucast->vlan == tmp->vlan) {
>  				DP_ERR(edev, "Unicast MAC is already added"
>  				       " with vlan = %u, vni = %u\n",
>
diff mbox

Patch

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ad264ba..a0616a4 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -571,6 +571,7 @@  static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn,
 		SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
 			if ((memcmp(mac_addr, &tmp->mac,
 				    ETHER_ADDR_LEN) == 0) &&
+			     ucast->vni == tmp->vni &&
 			     ucast->vlan == tmp->vlan) {
 				DP_ERR(edev, "Unicast MAC is already added"
 				       " with vlan = %u, vni = %u\n",