diff mbox

[dpdk-dev] net/ring: add missing newlines in logs

Message ID 20170706154750.27393-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Thomas Monjalon July 6, 2017, 3:47 p.m. UTC 
  Some logs are missing the newline character \n.

The logs using only line can be checked with this command:
	git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/

Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/ring/rte_eth_ring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit July 18, 2017, 8:08 a.m. UTC | #1 
On 7/6/2017 4:47 PM, Thomas Monjalon wrote:
> Some logs are missing the newline character \n.
> 
> The logs using only line can be checked with this command:
> 	git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
> 
> Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 820a41104..6ac96a6a2 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -494,7 +494,7 @@  static int parse_kvlist (const char *key __rte_unused, const char *value, void *
 
 	node = strchr(name, ':');
 	if (!node) {
-		RTE_LOG(WARNING, PMD, "could not parse node value from %s", name);
+		RTE_LOG(WARNING, PMD, "could not parse node value from %s\n", name);
 		goto out;
 	}
 
@@ -503,7 +503,7 @@  static int parse_kvlist (const char *key __rte_unused, const char *value, void *
 
 	action = strchr(node, ':');
 	if (!action) {
-		RTE_LOG(WARNING, PMD, "could not action value from %s", node);
+		RTE_LOG(WARNING, PMD, "could not parse action value from %s\n", node);
 		goto out;
 	}